Consider renaming "pk" to "pubkey" everywhere

jedisct1 / rust-minisign

A pure Rust implementation of the Minisign signature tool.

Other

92 stars 15 forks source link

Consider renaming "pk" to "pubkey" everywhere #4

Closed joshtriplett closed 4 years ago

joshtriplett commented 4 years ago

The abbreviation "pk" seems error-prone; it could abbreviate either "public key" or "private key". Does it seem reasonable to consider expanding it to something like "pubkey" instead?

I'd be happy to provide a patch for this, but I wanted to file an issue for discussion first.

jedisct1 commented 4 years ago

Hi Josh,

Without any context, pk may be confusing, but used in conjunction with sk, it's probably okay to keep it that way rather than introducing a breaking change.