search

jediwhale / fitsharp

Functional testing tools for .NET
http://fitsharp.github.io
Other
152 stars 73 forks source link

double values not culture specific #104

Closed starguy closed 11 years ago

starguy commented 12 years ago

I have a problem with culture specific settings for fitsharp. Although I'm passing a suite config:

de-DE

to fitnesse via COMMAND_PATTERN double values like 300,0 will still be interpreted as 3000 in my fitnesse pages. Have I forgot to set something, is there a solution for this problem?

I'm using fitnesse.jar in version 20111026 and fitsharp in version release 2.2 .net 4.0.

Any help would be appreciated.

starguy commented 12 years ago

<suiteConfig> <Culture> <Name>de-DE</Name> </Culture> </suiteConfig>

kimgr commented 12 years ago

Maybe your suite config is not found and you don't notice due to issue #74?

The culture is used by fitSharp's own Fit suite to force the tests to run in en-US, so I'm pretty sure it works for Fit. Not sure if Fitnesse runs are different.

starguy commented 12 years ago

the Parse Method in fitSharp.Slim.Operators.ParseDefault and the getter of ValueString in fitSharp.Machine.Model.TypedValue should use Thread.CurrentThread.CurrentCulture instead of CultureInfo.InvarianCulture

kimgr commented 12 years ago

Aha. CultureInfo.InvariantCulture is pretty close to en-US, so that explains why fitSharp's own tests still work on my machine (with a Swedish locale).

jediwhale commented 12 years ago

Good catch! I'll include this in my next update.

jediwhale commented 11 years ago

fixed

starguy commented 11 years ago

thx!

 

greets c

 

Gesendet: Freitag, 05. Juli 2013 um 22:46 UhrVon: "Mike Stockdale" notifications@github.comAn: jediwhale/fitsharp fitsharp@noreply.github.comCc: starguy cosmin@gmx.deBetreff: Re: [fitsharp] double values not culture specific (#104)

fixed

— Reply to this email directly or view it on GitHub.