search

jediwhale / fitsharp

Functional testing tools for .NET
http://fitsharp.github.io
Other
152 stars 73 forks source link

Parse operators trim whitespace #105

Closed kimgr closed 12 years ago

kimgr commented 12 years ago

After our discussion on Symbol trimming, I've done some work to make it more consistent.

Cell/CellBase/Parse/CellSubstring now have a Content property containing the Text as shown in the browser. This currently implies only that it's trimmed.

CellSubstring just returns its current Text; I left a TODO there, because I'm not sure if this is correct behavior.

The following operators have been updated to use Content instead of Text:

I'm sure there are more operators that should use Content over Text, but I didn't want to change them without understanding the ramifications; we only use parse operators.

I also tried to improve unit test coverage of parse operators at large and added a tidy HTML page with symbol operators in it, to check that this works end-to-end

Happy to hear what you think about this!

jediwhale commented 12 years ago

Thanks. I'm away from home on a very slow connection so I'll merge this when I get back. "Content" is a bit vague but I haven't thought of a better name yet :)

kimgr commented 12 years ago

Thank you.

I've actually grown to like Content -- I think of it as the content that's visible in the browser. Whitespace naturally disappears there. But yeah, it's not dramatically different from "Text" :)

On Tue, Aug 14, 2012 at 9:28 PM, Mike Stockdale notifications@github.comwrote:

Thanks. I'm away from home on a very slow connection so I'll merge this when I get back. "Content" is a bit vague but I haven't thought of a better name yet :)

— Reply to this email directly or view it on GitHubhttps://github.com/jediwhale/fitsharp/pull/105#issuecomment-7737287.

jediwhale commented 12 years ago

done