Sdk style projects

[sqeezy]

This PR is ment to change from "old" style msbuild projects to sdk style. In the process we could target netcoreapp3.0 and net472.

@jediwhale For me the first question to answer is whether the "old" style should be removed in complete or kept for now.

[sqeezy]

Will fix #166

[jediwhale]

Thanks. I'll review this as soon as I get some free time.

[sqeezy]

It's not quite finished yet. I will enable review when I'm. Pretty sure we need to itterate once, as I'm not sure about the structure of projects. Thanks for being so responsive though.

[sqeezy]

During this PR I switched the approach of how to integrate multitargetting a bit. I think a squash could help the understadability of this process a lot.

[jediwhale]

The current approach to multitargeting was done in a hurry - good to clean this up.

[sqeezy]

I'm pretty happy how it is now. If you want something different structure wise just let me know. I think it would be very helpfull to enable some kind of CI for this project. If you want any help with that, l would be happy to set something up.

[sqeezy]

There is still one test failing in the storytests, when running under dotnet core. I can't really grasp whats wrong there, or whether the test is supposed to fail. It seems Fit/CompareFloatingPoint is testing comparison of floating point division before and after adding the needed operator. In this case the test failing would be ok. But it seems to work in the full framework build. Can you help me on that? Other then this I'm done I think. I also set up an Github-Action to do rudimentary testing. For this I could open up a follow up PR if you are interested.

[jediwhale]

What is the output of the failing test? On 2019-12-16 02:36, Anton Herzog wrote:

There is still one test failing in the storytests, when running under dotnet core. I can't really grasp whats wrong there, or whether the test is supposed to fail. It seems Fit/CompareFloatingPoint is testing comparison of floating point division before and after adding the needed operator. In this case the test failing would be ok. But it seems to work in the full framework build. Can you help me on that? Other then this I'm done I think. I also set up an Github-Action to do rudimentary testing. For this I could open up a follow up PR if you are interested.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jediwhale/fitsharp/pull/167?email_source=notifications&email_token=AAAJOY7GX6TYYF7YRJMVXM3QY5DZPA5CNFSM4JY2VKX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6C3JA#issuecomment-565980580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJOY3NSISMWX37KMOAEUDQY5DZPANCNFSM4JY2VKXQ.

[sqeezy]

[jediwhale]

This is the reason https://scottdorman.blog/2019/04/03/floating-point-changes-in-net-core-3-0/ I'll have to think about what to do with the test.

[sqeezy]

Is there any way that I can help to move this PR forward?

[jediwhale]

I have fixed the test - I'll be able to proceed this week.

[sqeezy]

Is there any roadmap regarding this being released?

[jediwhale]

Binaries have been published to nuget, documentation updates over the next few days

[sqeezy]

Could you give me a quick hint in how to use the new Runner.dll via the fitnesse wiki. Alternatively Runner could stay an *.exe. That might prevent people from being confused, like I am now. I don't quite remember on why I didn't configure it that way. I would be happy to create a minimal example for that afterwards if you want one.

[jediwhale]

https://fitsharp.github.io/FitSharp/RunTestsWithFitnesse.html

[sqeezy]

Thank you. I forgot that netcore isn't a completely new feature.