kimgr
commented
13 years ago We've fixed (a) with [SetCulture] on affected tests, and (b) with support for an additional Culture setting in the suite config, so that fitSharp's test suite can be run in en-US.
Not sure if this is generally useful, or if other solutions are preferable -- this was mostly to be able to run fitSharp tests after modifications.
It seems to me that some mechanism for marking individual pages as requiring a specific culture would allow things like testing culture-dependent parsers without having to run the entire suite in said culture.
Attempting to run fitSharp's unit and acceptance tests on my Swedish development machine results in a slew of failures because of culture-dependent parsing of decimal/float/double.
I think it makes sense to parse numbers using the current locale, but it would be nice if;
a) the unit tests that parse number strings had a [SetCulture] attribute to force the current culture to en-US, to match the input data (BindingTest, CompareDefaultTest and ScientificDoubleTest are the current failures)
b) the fitSharp engine could be configured with a culture used for running all tests (in suite config), or if there was a way to mark single pages to run in a given culture
As for (a), I can give you a pull request with said tests marked with their required culture, but for (b) I'm not sure what's best.
Thanks,