jediwhale
commented
13 years ago manually applied selected changes
Closed kimgr closed 13 years ago
jediwhale
commented
13 years ago manually applied selected changes
kimgr
commented
13 years ago Hi Mike,
Thanks! I'm surprised to see that all our work on master has fallen into this pull request -- it looks like it points to master's latest rev, which is clearly not right.
I need to read up on how to do good pull requests...
Confused,
On Thu, Apr 21, 2011 at 23:02, jediwhale reply@reply.github.com wrote:
manually applied selected changes
Reply to this email directly or view it on GitHub: https://github.com/jediwhale/fitsharp/pull/68#issuecomment-1041384
jediwhale
commented
13 years ago Yes, I seem to mess them up about half the time :) Someday I'll be a git wizard!
On 2011-04-22 00:18, kimgr wrote:
Hi Mike,
Thanks! I'm surprised to see that all our work on master has fallen into this pull request -- it looks like it points to master's latest rev, which is clearly not right.
I need to read up on how to do good pull requests...
Confused,
- Kim
On Thu, Apr 21, 2011 at 23:02, jediwhale reply@reply.github.com wrote:
manually applied selected changes
Reply to this email directly or view it on GitHub: https://github.com/jediwhale/fitsharp/pull/68#issuecomment-1041384
Cheers, Mike Stockdale
/fit/Sharp http://fitsharp.github.com Syterra Software Inc. http://www.syterra.com
I haven't found a way to cherry-pick commits when creating a pull request, so here's an offering of fixes for;
Issue #64: -o switch ignored? Issue #65: fitSharp tests fail in non-en-US culture Already pull-requested issue #67: The VS version selector cannot parse Unix line endings
Sorry it's all in a big chunk, next time we'll branch before fixing.
I think the most controversial may be the new Culture element in suiteconfig.xml, we could think of no better way to specify culture for the fitSharp test suite so we could run it outside of en-US.
Hope that helps,