consider merging app domain setup feature

[authorunknown]

Hello, I implemented a feature in the fitsharp test runner for my team and would like you to consider integrating it into the main project. We are working on an application that required the app domain that the tests run in be setup in a certain way. I created a command line switch for the test runner to read a System.IAppDomainSetup object from an xml file and then use that to create the test app domain.

If you take a look at git://github.com/authorunknown/fitsharp.git the changes are in two places:

• fitSharp.Machine.Application.AppDomainParameters (new class)
• fitSharp.Machine.Application.Shell

[kimgr]

Just thinking out loud -- would it be better to put this configuration in SuiteConfig.xml?

I cringe a little at the thought of another .xml file besides SuiteConfig and App.config, but on the bright side this solution is more versatile than reading it from SuiteConfig.

Thoughts?

Thanks,

• Kim

[authorunknown]

sorry for the long delay. (vacation was fun :). yes, I suppose I hadn't considered that because our project didn't use a SuiteConfig.xml. However, I see your point. I'll do a little refactoring and push the result

[kimgr]

It was just a thought, I'm not sure if it has merit :-)

Maybe Mike has a more pointed opinion on this...

Happy holidays, if applicable,

• Kim

[jediwhale]

Added AppDomainSetup section to suite configuration file. Easier than I expected. Uses the System.AppDomainSetup class and its properties directly, then Shell uses this to create the AppDomain.