jedkohjk / pe

0 stars 0 forks source link

Overzealous validation of birthdays #6

Open jedkohjk opened 10 months ago

jedkohjk commented 10 months ago

Changes in system time can reasonably happen when changing OS (not updated), when changing timezones, or by setting directly.

We may resonably want to set a birthday to a future date, in a timezone that is ahead of us.

However, this is not allowed by the app.

nus-se-bot commented 9 months ago

Team's Response

Due to a lack of reproducing steps, I'm unable to identify what conditions should be satisfied to produce the bug. For example, was the timezone change done when the application was open or closed?

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: I reported a feature flaw, not a functionality bug. Hence, I was commenting that blocking future dates is not ideal, not that there are specific steps that, if followed, cause an error.

Hence, I stated that changes in system time can happen. This is regardless of when those changes in system time occur (whether the application is open or closed).

The issue is a feature flaw because it is reasonable that we want to store future dates (based on our system time) as birthdays.

Here are 2 possible scenarios where it may not be ideal:

Allowing future dates serves to make the app more flexible and account for the above scenarios. I do not see how allowing future dates would can hinder the operations of the software. I believe this fits the course website's description of overzealous input validation:

Screenshot (323).png

I believe my explanation of the issue was sufficiently clear in the original report. I do not think the dev team's requirement of reproducing steps is justified for a feature flaw like the one I raised.