search

jednano / eclint

Validate or fix code that doesn't adhere to EditorConfig settings or infer settings from existing code.
MIT License
307 stars 28 forks source link

Doesn’t work on Travis CI (node 0.10.x), throws Unhandled rejection TypeError #30

Closed jirutka closed 9 years ago

jirutka commented 9 years ago 
$ eclint check $(git ls-files)
Unhandled rejection TypeError: Object # h has no method 'equals'
    at detectCharset (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/linez/js/linez.js:35:41)
    at linez (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/linez/js/linez.js:19:19)
    at /home/travis/.nvm/v0.10.36/lib/node_modules/eclint/js/eclint.js:69:27
    at tryCatcher (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/promise.js:503:31)
    at Promise._settlePromiseAt (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/promise.js:577:18)
    at Async._drainQueue (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/async.js:15:14)
    at process._tickCallback (node.js:442:13)
jednano commented 9 years ago

This issue should be filed with the linez project.

jednano commented 9 years ago

BTW, this is using Buffer#equals and all the tests pass fine on Travis for the linez project. If you can submit a breaking build I'll be happy to fix it.

jirutka commented 9 years ago

It’s this build from this branch, eclint is called in script/test:17.

jednano commented 9 years ago

Again, this is an issue with the linez project. Please file the issue there.

jirutka commented 9 years ago

So what does your previous comment mean? o.O

If you can submit a breaking build I'll be happy to fix it.

jednano commented 9 years ago

I'm the owner of both projects. Perhaps I should have said a breaking test.

jednano commented 9 years ago

Real fix in v1.1.0: https://github.com/jedmao/eclint/commit/f3a87fb382d53ae4f2f8eb694556bda5d208d850