search

jednano / eclint

Validate or fix code that doesn't adhere to EditorConfig settings or infer settings from existing code.
MIT License
307 stars 28 forks source link

1.1.3 is an empty release #34

Closed denis-sokolov closed 8 years ago

denis-sokolov commented 8 years ago

PRs #32 and #33 only modify the source. I did not notice that the project has build artifacts in the repository. Please consider #33 and then rebuild to ensure that the JavaScript version is updated.

Consider not keeping build artifacts in the repository. Although not universally accepted, I'd say it's a generally accepted practice.

Sorry for the inconvenience.

jednano commented 8 years ago

Fixed in v1.1.5, where I also added npm test to the prepublish script so that an empty release won't happen again.

I totally agree with not keeping build artifacts in the repo. I definitely don't do that with new projects. Anyway, the build artifacts were removed in https://github.com/jedmao/eclint/commit/93aa94904220e050cbb1470dbd6f4c0925e56aa1.

Thanks again!