search

jednano / eclint

Validate or fix code that doesn't adhere to EditorConfig settings or infer settings from existing code.
MIT License
305 stars 28 forks source link

fail to recognize utf-8-bom #40

Closed hax closed 7 years ago

hax commented 8 years ago 
echo test > test
eclint fix -c utf-8-bom test
eclint check -c utf-8-bom test

output:

test: expected charset: utf-8-bom

It seems eclint fix add bom successfully, but eclint check fail to recognize it... :fearful:

hax commented 8 years ago

eclint version: 1.1.5 node version: 5.8.0

jednano commented 8 years ago

Can you provide a failing test? Because there is already a test for this here: https://github.com/jedmao/eclint/blob/master/lib/rules/charset.spec.ts#L72-L77

hax commented 8 years ago

I already give you the test (3 lines shell script) in my first comment. You can just run it.

I know you have the testcase, but unfortunately the feature is still broken, and I don't know why.

gucong3000 commented 7 years ago

@hax fixed, try 1.1.5