search

jednano / eclint

Validate or fix code that doesn't adhere to EditorConfig settings or infer settings from existing code.
MIT License
305 stars 28 forks source link

Skip binary files #45

Closed fregante closed 7 years ago

fregante commented 7 years ago

If I were to run

$ eclint check *

eclint runs on all binary files, but these should be ignored, perhaps using is-binary-path as a blacklist or is-text-path as a whitelist

alexander-akait commented 7 years ago

/cc @jedmao

jednano commented 7 years ago

The EditorConfig js core is one of many cores and should be the one responsible for handling this request. I think this issue would be best requested in the general EditorConfig issue tracker so that all cores would ignore binary files, if accepted. Until then, i don't think this is an eclint concern.

jednano commented 7 years ago

Reopening in response to https://github.com/editorconfig/editorconfig-core-js/issues/42#issuecomment-273396875. Willing to accept a PR, but I'm not really maintaining this project any more these days.

gucong3000 commented 7 years ago

@bfred-it fixed in master branch.

fregante commented 7 years ago

Excellent! Thank you 🙂

jednano commented 7 years ago

I haven't released what's on master yet though. I'm waiting for https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14996.

jednano commented 7 years ago

The type def has landed!