search

jednano / linez

Parse lines from text.
4 stars 2 forks source link

Doesn’t work on Travis CI (node 0.10.x), throws Unhandled rejection TypeError #13

Closed jirutka closed 9 years ago

jirutka commented 9 years ago 
$ eclint check $(git ls-files)
Unhandled rejection TypeError: Object # h has no method 'equals'
    at detectCharset (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/linez/js/linez.js:35:41)
    at linez (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/linez/js/linez.js:19:19)
    at /home/travis/.nvm/v0.10.36/lib/node_modules/eclint/js/eclint.js:69:27
    at tryCatcher (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/promise.js:503:31)
    at Promise._settlePromiseAt (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/promise.js:577:18)
    at Async._drainQueue (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (/home/travis/.nvm/v0.10.36/lib/node_modules/eclint/node_modules/editorconfig/node_modules/bluebird/js/main/async.js:15:14)
    at process._tickCallback (node.js:442:13)

Copied from https://github.com/jedmao/eclint/issues/30.

jednano commented 9 years ago

Can you submit a breaking "test"?

jednano commented 9 years ago

Because I am unable to reproduce this one.

jirutka commented 9 years ago

Well, it’s extremely easy to reproduce this error. I’ve created example in this repo and you can see the described error here. It doesn’t fail the build though, because it returns 0 even on exception.

jirutka commented 9 years ago

You have 8 failing tests on 0.10.x, but since it’s badly configured, it exits with success, so you haven’t noticed that.

jednano commented 9 years ago

Thanks for pointing me in the right direction. Fixed in https://github.com/jedmao/linez/commit/3a769a5314cfd840f5c2fa859f75f27fd7a5bdb2 and https://github.com/jedmao/linez/commit/3a769a5314cfd840f5c2fa859f75f27fd7a5bdb2.

jednano commented 9 years ago

Real fix in https://github.com/jedmao/linez/commit/cfcbd035e0a4cb2013353ab0df225c9f7bf23bd3.