search

jednano / vscode-tabsanity

Arrow-key navigation through soft tabs as if they were hard tabs.
MIT License
12 stars 2 forks source link

Matched quote/paren/brace/braket deletion #17

Closed daphil19 closed 6 years ago

daphil19 commented 6 years ago

Tabsanity appears to break the ability to delete adjacent, matching pair of characters like:

[]
()
{}
''

etc.

Example (in .js file) peek 2018-02-09 15-13

jednano commented 6 years ago

Hmm, that looks like perhaps a tough one to fix. Willing to accept PRs, but I don't think I'll be going down this road myself. Thanks for logging the issue!

peterctl commented 6 years ago

I did a small test on my local computer. It seems that deleting the backspace functionality solves this issue. Also, VS Code has the functionality to delete whitespace until the next tab stop when backspace is pressed, so it seems to me that including such functionality in this extension is redundant.

I think this was added to the editor core recently, so it shouldn't be needed anymore. I can do a PR in a week or two since I am on finals week at my university. Please let me know if I'm missing something or if I should do the PR to remove the delete functionality from the extension.

jednano commented 6 years ago

@PeterCP I would greatly appreciate a PR. Thanks!

jednano commented 6 years ago

Published in v0.0.10. Thanks for the help!

peterctl commented 6 years ago

Thanks to you for making such an awesome and useful extension 😀 cheers!