search

jednoprsak / PuppetNetworkManagerModule

Puppet module which installs, configures, and controls NetworkManager
MIT License
2 stars 7 forks source link

no additional ipv4/6 configuration when disabled #24

Open kbucheli opened 6 months ago

kbucheli commented 6 months ago

This PR refactors the ipv4 and ipv6 configuration hash generation into a own function each.

In these functions additional configuration is only attached if the respective family is enabled.

On my test node (using only connection resources :-( ) I get now no additional configuration except that IPv4 and IPv6 are disabled. 

[root@lxdev08 ~]# cat /etc/NetworkManager/system-connections/sniffer.nmconnection 
# THIS FILE IS CONTROLLED BY PUPPET

[connection]
interface-name=ens224
id=sniffer
uuid=ddc5b71b-d603-5c1e-a8c7-03b11d9b00c1
type=ethernet

[ipv4]
method=disabled

[ipv6]
method=disabled
[root@lxdev08 ~]#
kbucheli commented 4 months ago

Do you find a minute or two to look at this pull request?

jednoprsak commented 4 months ago

Thank you for your reminder. We will look at it when we have time.