search

jeduan / cordova-plugin-facebook4

Use the latest Facebook SDK in your Cordova and Ionic projects
Other
765 stars 510 forks source link

Login returns with cancelled result on iOS 13 #802

Closed yosikal closed 4 years ago

yosikal commented 5 years ago

Login returns with cancelled result on iOS 13. Updating Facebook SDK to version 5.6.0 solves this issue.

However, when updating the SDK to version 5.6.0 I encountered different problem of method openURL (newer) being called in infinite loop. I solved it for now by commenting out the newer function.

francescotonini commented 4 years ago

@jeduan Is there any ETA for this fix? Unfortunately it's pretty critical since it breaks the plugin on iOS 13

peterpeterparker commented 4 years ago

@francescotonini PR are welcomed

jeduan commented 4 years ago

@francescotonini If this is critical, I recommend hiring a developer with solid understanding of Cordova to fix this and consider contributing that back.

francescotonini commented 4 years ago

Of course I will try to send a PR with a fix, I was just wondering if someone was already working on it since this plugin it's used by a significant amount of developers.

peterpeterparker commented 4 years ago

PR from @francescotonini (thx again 👍) has been merged. Plugin v6.1.0 has been released. Therefore this should be solved.

Ping me if not to reopen the issue.

peterpeterparker commented 4 years ago

@yosikal could you check the openUrl problem. if doesn't we should reopen the issue too. thx

francescotonini commented 4 years ago

Thanks @peterpeterparker and apologies for my first comment on this issue, it's a bit over the line.

peterpeterparker commented 4 years ago

@francescotonini no problem at all!

keep me posted about this in case it should be reopened, thx in advance