search

jeduan / cordova-plugin-facebook4

Use the latest Facebook SDK in your Cordova and Ionic projects
Other
765 stars 510 forks source link

This plugin overwrites other plugin configuration #828

Closed dminkovsky closed 4 years ago

dminkovsky commented 4 years ago

As commented https://github.com/EddyVerbruggen/cordova-plugin-googleplus/issues/613#issuecomment-547638500:

Before installing this plugin, my info plist contained a URL type (CFBundleURLTypes)

``` CFBundleDevelopmentRegion en_US CFBundleDisplayName Pony CFBundleExecutable $(EXECUTABLE_NAME) CFBundleIdentifier $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 CFBundleName $(PRODUCT_NAME) CFBundlePackageType APPL CFBundleShortVersionString 1.0.0 CFBundleSignature ???? CFBundleVersion 1.0.0 LSRequiresIPhoneOS NSMainNibFile NSMainNibFile~ipad UIRequiresFullScreen UISupportedInterfaceOrientations UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UISupportedInterfaceOrientations~ipad UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeRight NSAppTransportSecurity NSExceptionDomains accounts.google.com NSAllowsArbitraryLoads CFBundleURLTypes CFBundleTypeRole Editor CFBundleURLName REVERSED_CLIENT_ID CFBundleURLSchemes com.googleusercontent.apps.myid ```

With this plugin installed, that URL type has been replaced by the one specified by this plugin:

``` CFBundleDevelopmentRegion en_US CFBundleDisplayName Pony CFBundleExecutable $(EXECUTABLE_NAME) CFBundleIdentifier $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 CFBundleName $(PRODUCT_NAME) CFBundlePackageType APPL CFBundleShortVersionString 1.0.0 CFBundleSignature ???? CFBundleVersion 1.0.0 LSRequiresIPhoneOS NSMainNibFile NSMainNibFile~ipad UIRequiresFullScreen UISupportedInterfaceOrientations UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UISupportedInterfaceOrientations~ipad UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeRight NSAppTransportSecurity NSExceptionDomains m.facebook.com graph.facebook.com api.facebook.com fbcdn.net NSIncludesSubdomains akamaihd.net NSIncludesSubdomains accounts.google.com NSAllowsArbitraryLoads FacebookAppID myid FacebookDisplayName Pony FacebookHybridAppEvents false CFBundleURLTypes CFBundleURLSchemes myid LSApplicationQueriesSchemes fbapi fb-messenger-api fbauth2 fbshareextension ```
peterpeterparker commented 4 years ago

Could you provide a PR @dminkovsky?

dminkovsky commented 4 years ago

This may be related: https://github.com/apache/cordova-common/pull/89 Quite new to Cordova, and still investigating this issue :).

peterpeterparker commented 4 years ago

If anyone could provide a PR, ping me, happy to merge it

dminkovsky commented 4 years ago

I can report that, as per https://github.com/apache/cordova-ios/issues/581, this problem is not present with 8.1.1/4.5.5. (I had been using 9.0.0/5.0.1). Which makes me think that the problem is, as with that issue, related to https://github.com/apache/cordova-common/pull/89.

However, when I tried installing using a custom built cordova-cli and cordova-ios with cordova-common patched per https://github.com/apache/cordova-common/pull/89, I still experienced this problem.

dminkovsky commented 4 years ago

Either way, I think this is an issue with Cordova. I don't think a PR with something like edit-config will fix this issue. Closing for now.

peterpeterparker commented 4 years ago

Thx for the analysis @dminkovsky 👍 Ping me if you think that should be reopened later on or create a new issue referencing this one.

dminkovsky commented 4 years ago

Thank you @peterpeterparker. I am double checking over at cordova-common (https://github.com/apache/cordova-common/pull/89#issuecomment-547979264), and for now will likely do something like https://github.com/apache/cordova-ios/issues/581#issuecomment-518096070 as a workaround.