search

jeduan / cordova-plugin-facebook4

Use the latest Facebook SDK in your Cordova and Ionic projects
Other
764 stars 509 forks source link

Fix Facebook login on iOS 13 #860

Closed jonasmeier1212 closed 3 years ago

jonasmeier1212 commented 4 years ago

Applied fix from here: https://github.com/jeduan/cordova-plugin-facebook4/issues/826 This fix works without problems on all iOS version. It implements the code examples from Facebook in the plugin code, which makes additional docu or post scripts obsolete.

peterpeterparker commented 4 years ago

@jonasmeier1212 thx for the PR

what do you mean with "which makes additional docu or post scripts obsolete."? should also the docs be updated, if so, could you add the change to the PR too?

peterpeterparker commented 4 years ago

@jonasmeier1212 is the PR really needed ? I just tested current version of the plugin as described in #826 with my iPhone 6s iOS 13.3 and I'm unable to reproduce the problem.

Therefore too me this doesn't have to be merged or how could effectively be the problem be reproduced?

lonwi commented 4 years ago

@peterpeterparker You need to have a Facebook App installed to replicate the problem just in case. I had to clear all safari data as well as it remembered my login without the Facebook App installed. I was able to replicate the issue on ios 13.3 and 13.5 on a couple of the devices.

kleeb commented 4 years ago

I was able to reproduce that on iPhone 6 with iOS 12.4.3 and on iPhone 8 Plus with iOS 13.5.1. Its not occuring on iPhoneX with iOS 13.4.

This PR is nothing else like an add-on to this issue https://github.com/facebook/facebook-ios-sdk/issues/1400 Let's not wait longer with merging.

rareplanet1 commented 4 years ago

Will this be merged? Reproduced today on iOS 14.2 on iPhone 12 mini and iPhone 7 Plus Using cordova-ios@6.1.1 and cordova-plugin-facebook4@6.4.0

anuradha-newpage commented 3 years ago

Is this going to be merged anytime soon? The issue occurs on iOS 14.2 with cordova-plugin-facebook4@6.4.0 and capacitor/ios@2.4.1

noahcooper commented 3 years ago

This plugin is deprecated. Check out cordova-plugin-facebook-connect. I've included the changes from the PR by @jonasmeier1212:

https://www.npmjs.com/package/cordova-plugin-facebook-connect