jeduan / cordova-plugin-facebook4

Use the latest Facebook SDK in your Cordova and Ionic projects
Other
767 stars 511 forks source link

unable to upgrade to FB SDK (iOS) 8.1.0 #892

Closed Zvika88 closed 3 years ago

Zvika88 commented 3 years ago

Trying to mitigate FB's warnings about out of date SDK , I tried updating the pod reference from the previous (working!) 5.7.0 to the latest 8.1.0 for FBSDKCoreKit, FBSDKLoginKit, FBSDKShareKit.

I am getting a bunch of errors in XCode when trying to build the app:

What needs to be done in order to update the SDK? What is the latest supported SDK?

Thanks!

Screen Shot 2020-11-10 at 2 56 12 AM

6ewis commented 3 years ago

@Zvika88 did you manage to fix it? were you able to update to the latest version?

S-Asakoto commented 3 years ago

Faced with the same problem, but reimporting FB SDK version 5.15.1 solved the problem. This seems to be due to that FB removed these classes as obsolete in version 6 onwards, while the plugin is still using these classes. Since the versions 6 to 8 published within just a year, the author could have not noticed that. (At least version 5.15.1 was published in Jan 2020)

rgustavsson commented 3 years ago

Obviously the latest supported SDK for this plugin is 5.X It would be awesome if someone could manage to upgrade to the latest Facebook SDK. I might even pay you ;)

rgustavsson commented 3 years ago

I'll pay $500 to anyone that upgrades within 3 weeks.

pellaras commented 3 years ago

I'll pay $500 to anyone that upgrades within 3 weeks.

@rgustavsson: Here you go: https://github.com/pellaras/cordova-plugin-facebook4

Please pay here. ;)

rgustavsson commented 3 years ago

@pellaras good news! I'll test it asap :) May I ask for a clarification around the commented out code in the iOS upgrade? (FacebookConnectPlugin.m) Do you know when "share_open_graph" is used/needed?

pellaras commented 3 years ago

Hi @rgustavsson, not sure, but seems to be a depreciated feature: https://developers.facebook.com/community/threads/428042001393940/

xcode was complaining about that portion, and the facebook sdk change logs shows them as been removed

rgustavsson commented 3 years ago

@pellaras ah, thank you. So we should basically make sure that:

May I ask if you use this plugin in any project?

pellaras commented 3 years ago

@rgustavsson

This repo is no longer maintained, so merging it will prove challenging

Quite a few, but to be fair, mostly for analytics.

rgustavsson commented 3 years ago

@pellaras True!

@jeduan I'd be happy to take ownership so that this plugin stays up to date. It would be a pitty to work on different forks.

daksamedia commented 3 years ago

Hi @pellaras

is this repo still under your maintain? https://github.com/pellaras/cordova-plugin-facebook4

I see that repo updated 2 days ago. I'm glad if you answer me.

Thank you

rgustavsson commented 3 years ago

@daksamedia please follow our discussion above, we're discussing ownership/maintenance. It would be stupid not to try to align this repo with the latest development

daksamedia commented 3 years ago

@daksamedia please follow our discussion above, we're discussing ownership/maintenance. It would be stupid not to try to align this repo with the latest development

I see, I'd be happy if you or anyone else take this ownership / maintenance, 'cause this is one of important plugin in Cordova. Thank you for answering me.

pellaras commented 3 years ago

Hi @daksamedia, that's my fork and only has a few changes needed for the apps I am involved with. I wouldn't say it's actively maintained.

noahcooper commented 3 years ago

FYI - I've created https://github.com/cordova-plugin-facebook-connect/cordova-plugin-facebook-connect and will be working on updating it to the most recent version of the Facebook SDK.

rgustavsson commented 3 years ago

Everyones going to have their own fork.. Why not collaborate??

rgustavsson commented 3 years ago

@jeduan seems to have abandoned the ship without wanting to transfer ownership 😞

jeduan commented 3 years ago

@rgustavsson friendly reminder that I don’t owe you anything. Your comment comes off as extremely entitled. maintainer burnout from handling entitled GitHub posters is the main reason me and other folks have stopped working on this and other open source projects. Be better.

rgustavsson commented 3 years ago

@jeduan if you take the responsibility to own/maintain an open source repo then you also take the responsibility to answers requests - especially requests about helping out. I’ve tried to reach you here and via LinkedIn without any luck. I won’t apologize as I believe you can handle things better.

jeduan commented 3 years ago

@rgustavsson take that energy and put it in your own (open source or otherwise) projects.

noahcooper commented 3 years ago

This issue is fixed in the new plugin cordova-plugin-facebook-connect!

https://www.npmjs.com/package/cordova-plugin-facebook-connect