search

jedwards1211 / meteor-imports-webpack-plugin

Webpack plugin to import and use Meteor packages like if they were real NPM packages.
MIT License
25 stars 10 forks source link

Different things #16

Open staeke opened 7 years ago

staeke commented 7 years ago

Hi Luis!

I just wanted to let you know I have been working on this. Also, I'm fixing so that css/static files can be imported from Meteor. We've stumbled upon some different problems and these are all fixes. Do you want me to spread out these changes on multiple PRs? Chat about them? I'm open to whatever.

Cheers

jedwards1211 commented 7 years ago

@staeke oh, does the special handling for modules.js make meteorInstall calls work?

luisherranz commented 7 years ago

This is awesome, @staeke :)

Is it 100% backwards compatible? Can we release it v1.2.0?

staeke commented 7 years ago

@jedwards1211 principally yes. If your code depends on a global variable meteorInstall being there, you might need to have something like const meteorInstall = Package['modules-runtime'].meteorInstall instead.

@luisherranz cool. It should be backwards compatible. I haven't run it on Windows though. With all the escaping for paths I'm not 100% confident that there won't be any problems. Guess I could try out in a VM box when I have the time. So the way forward I see is

BTW...soon getting out a PR with support for css/font packages etc.

luisherranz commented 7 years ago

Ok, my take is... we release it as 1.2.0 now and we try to test it as soon as we can.

I've added you as collaborator both here and in npm so you can go ahead with this.

@jedwards1211 can we merge this with v2 beta? Are you still working on that?

jedwards1211 commented 7 years ago

@luisherranz yes, that sounds good to me! Crater will help us test this. I may not get to it until this weekend though, feel free to remind me.

luisherranz commented 7 years ago

@jedwards1211 awesome, thanks!