json3 and crypto-browserify missing devDependencies?

jedwards1211 / meteor-webpack-react

(DEPRECATED) use jedwards1211/crater instead

https://github.com/jedwards1211/crater

374 stars 75 forks source link

json3 and crypto-browserify missing devDependencies? #84

Open grigio opened 8 years ago

grigio commented 8 years ago

I've a working meteor-webpack project, but if I start a new one I get this:

npm install
...
> grunt --gruntfile node_modules/core-js/Gruntfile.js build:es5,es6,es7,js,web --blacklist=es6.number.constructor --path=core-js-no-number

Loading "grunt-karma.js" tasks...ERROR
>> Error: Cannot find module 'json3'

Running "build:es5,es6,es7,js,web" (build) task
Warning: Cannot find module 'crypto-browserify' Use --force to continue.
...

jedwards1211 commented 8 years ago

I'm confused, npm install shouldn't be triggering the custom core-js build. Did you do something else? Also when did you last pull? I pushed a fix for one similar issue last night.

jedwards1211 commented 8 years ago

In any case going to node_modules/core-js and npm install-ing there before node dev.js or whatever may make the core-js custom build work

grigio commented 8 years ago

Yes node dev.js, i fixed with npm install -g json3 and after some warning it seems it works in fallback mode, because 'crypto-browserify' is just a warning Yes on a today fresh git clone.