search

jedypod / open-display-transform

Open Display Transform is a collection of tools and experiments for rendering wide-gamut scene-linear data into an image for an SDR or HDR display device.
GNU General Public License v3.0
192 stars 25 forks source link

Nayatani_HK.dctl with DR17/ATI/W10 #6

Closed ConnecTEDDD closed 3 years ago

ConnecTEDDD commented 3 years ago

Dear Jed,

Thank you in advance for your work/updates.

The first and the newer Nayatani_HK.dctl are not working in Windows 10 with Resolve 17.2.2 and ATI Radeon VII.

Propably it has a syntax in code that is not supported by ATI GPU.

Gamut Compress 0.7 had a similar issue, but you/Nick have solved it: https://github.com/jedypod/gamut-compress/issues/4

Thank you.

Ted.

jedypod commented 3 years ago

Hey @ConnecTEDDD Thanks for opening an issue about this!

After a little digging, it looks like degrees and radians are built-in functions in OpenCL. I've renamed these in this commit, which hopefully fixes the issue. What I wouldn't give for tracebacks in DCTL! Debugging is a real pain in this language...

Give it a test and let me know!

ConnecTEDDD commented 3 years ago

Hi Jed,

Thank you for taking a look; now it's working.

BTW, BMD had a webinar about DCTL some days.

I have asked the following question to the chat:

''Can you reference the line of code in the error log in case of syntax error? How do you find it a large script?''

Paul Dore replied:

''There is a workaround, albeit a not very practical one.

You subtract a certain value from the line number to find the actual line in the DCTL script.''

jedypod commented 3 years ago

Glad to hear it's working! I'll close the issue.

Also, thanks to your comment I have discovered that there is actually an error log! On linux it's in <resolve_install_dir>/logs/rollinglog.txt

I did not know about this before. The DCTL Compilation error doesn't provide the right line number, but it does provide some useful information to track down the issues at least! This will save me a ton of time in the future, so thank you very much! :)

ConnecTEDDD commented 3 years ago

According to the same BMD chat, the Resolve.log is the debugging tool for DCTL development, but it will include all DaVinci errors.