search

jeeeyul / eclipse-themes

Full Featured Eclipse Theme Customizer!
828 stars 121 forks source link

Linux Huge Toolbar Problem - GTK3 improvement proposition #258

Open mateusz-matela opened 7 years ago

mateusz-matela commented 7 years ago

Current instruction in wiki didn't work for me, but this style did:

GtkToolbar {
    padding: 0px;
}

I'm not expert on GTK so I'm not confident enough to update the wiki myself - maybe you know about something else that might break without the #swt-toolbar-flat selector.

I also found that you can have a similar solution as with GTK2 - create a customization file in user's home directory instead of changing the theme files directly. The file is ~/.config/gtk-3.0/gtk.css.

Tested in Ubuntu 16.4 + Eclipse 4.6.1.

renataogarcia commented 7 years ago

The issue with not being specific with the selector (#swt-toolbar-flat) is that it will remove padding from all your GtkToolbar components, even outside Eclipse. Maybe the selector has changed in Neon? If you use the CSS inspector you should be able to check it.

I think that updating ~/.config/gtk-3.0/gtk.css is probably a better solution than updating the theme, so I would encourage you to update the wiki with this info as the preferred method, but keeping the other as an alternative option and maybe remove it in the future.

mateusz-matela commented 7 years ago

I've checked with the css inspector and if I didn't miss anything, the only style classes used on toolbars now are toolbar horizontal, so it doesn't look like something that can be used limit the effect to Eclipse.

I'll update the wiki in a moment about gtk.css. I thought you could add a wizard that would create this file automatically. If not, this issue can be closed.

renataogarcia commented 7 years ago

Sorry, I realised now that the issue is probably not with the Neon selector itself. You need to look at the selector on the GtkToolbar of the code that is being used the max height. (The wiki has a link to the code in the GTK3 instructions too).

I think that generating the file in the home directory with the correct selector for GTK3, in the same way it's done for GTK2 could be useful. However I believe this is a workaround, so ideally it would be better to fix the code that is calculating the max height?

P.S. I'm not the maintainer of this repo.