jeeftor / EmojiTaco

Alfred Emoji Script with Taco and other unicode 9 emoji
78 stars 3 forks source link

No longer works OOB on macOS 12.3 #27

Closed querkmachine closed 2 years ago

querkmachine commented 2 years ago

Emoji Taco v1.2.3 — macOS 12.3 beta.

I've just updated to the macOS 12.3 beta that dropped a couple of days ago (I live dangerously) and Emoji Taco no longer works. No errors or glitches, anything after the initial Alfred keywords (aka, involves running a python script) just doesn't work.

My assumption is that this is because macOS 12.3 removes the bundled version of Python 2 (something Apple apparently said they were going to do in 2019). Bit weird of them to do that in a minor release, but that's Apple for ya.

Just giving a head's up in case no one has pointed this out yet!

jeeftor commented 2 years ago

https://github.com/jeeftor/EmojiTaco/releases/tag/v1.2.15

Ok I pushed a new release.

Main issue is that init emoji gives you ZERO feedback and you have to just assume it will work ...

So run that wait like 5-10 mins and then try to search for emoji and give me some feedback. Won't likely try again to fix stuff until tomorrow...

godbout commented 2 years ago

init emoji fails :frown:

[13:57:15.335] ERROR: Emoji Taco[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.CD0D6581-5808-4A7F-AE02-0A490C0AE922%3E7D136522-923D-4ACA-AAE1-14513A3840A1)] JSON error: JSON text did not start with array or object and option to allow fragments not set. around line 1, column 0. in JSON:
b'\xaf2\x01\x00'
78511
{
  "items": [
    {
      "title": "Starting background process",
      "subtitle": "",
      "valid": false
    }
  ],
  "variables": {
    "count": 0
  },
  "rerun": 1.5
}
jeeftor commented 2 years ago

Yea I've been seeing a lot of the same errors -> what I saw on my end, however, was even after that error message it kept actually downloading the emoji in the background...

image

And once they were downloaded it started working... do you see the same behavior?

jeeftor commented 2 years ago

My suspicion is the way that strings work in Python2 vs Python3 unicode strings are different... I may take a pause on this workflow until I can port my progress bar:

image

over to Python3 in which case it might solve some of the issues. Its a MUCH simpler codebase I think

There are also other issues ... but see if you can search emoji right now...

jeeftor commented 2 years ago
image

I got the progress workflow working with Python3 - and I found

I also see the current version is "stupid" shall we say:

image

is returning:

\U0001F1E8\U0001F1E6\U0000FE0F

And now I can no longer spam my Canadian coworkers with Canada flags!! NOOO

godbout commented 2 years ago

Yea I've been seeing a lot of the same errors -> what I saw on my end, however, was even after that error message it kept actually downloading the emoji in the background...

image

And once they were downloaded it started working... do you see the same behavior?

AH. my bad. apologies. you were right, emojis were downloaded and could be parsed. but like you i can't spam Canadians :e_sweat:

jeeftor commented 2 years ago

Getting closer:

image
jeeftor commented 2 years ago

Downloading and processing works -> its just the actual plugin that returns unicode strings and not the actual emoji that needs a patch

godbout commented 2 years ago

i'm currently back to using EmojiTaco and it's awesome. even with the unicode string \U0001F600\U0000FE0F i'm just asking people to go on google and check the 4th result, then they can see the emoji: https://www.google.com/search?q=%5CU0001F600%5CU0000FE0F

\U0001F44D\U0000FE0F

jeeftor commented 2 years ago

I just need some more boring meetings and I can finish this off :)

godbout commented 2 years ago

\U0001F64F\U0000FE0F

jeeftor commented 2 years ago
image

It should just work ... !!! 😠

I know I'm just down to some super easy fix ... just can't figure out what it is yet

jeeftor commented 2 years ago

🌮ī¸đŸ–ī¸đŸĨŠī¸

It Works!! (Expect a new release tonight/tomorrow)

jeeftor commented 2 years ago

https://github.com/jeeftor/EmojiTaco/releases/tag/v2.0.0-beta-1

Lemme know what bugs I've added!

godbout commented 2 years ago
[13:46:17.150] ERROR: Emoji Taco[[Script Filter](alfredpreferences:workflows%3Eworkflow%3Euser.workflow.CD0D6581-5808-4A7F-AE02-0A490C0AE922%3E157AEB44-CD30-445B-B751-7CEDE94BC8A0)] Code 1: Traceback (most recent call last):
  File "src/esearch.py", line 8, in <module>
    from workflow import Workflow3
ModuleNotFoundError: No module named 'workflow'

e frown

jeeftor commented 2 years ago

Same error on init and debug?

Sent from my iPhone

On Apr 5, 2022, at 11:47 PM, G. @.***> wrote:

īģŋ [13:46:17.150] ERROR: Emoji Taco[Script Filter] Code 1: Traceback (most recent call last): File "src/esearch.py", line 8, in from workflow import Workflow3 ModuleNotFoundError: No module named 'workflow' e frown

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

pat-s commented 2 years ago

@jeeftor The workflow folder is missing in https://github.com/jeeftor/EmojiTaco/tree/py3/src. Maybe you just forgot to commit it? :)

jeeftor commented 2 years ago

Yea I realized that. It's a symlink which I assumed would be included if I directly exported from Alfred.

I'm updating the workflow lib at the same time. I'll push an update today

godbout commented 2 years ago

Yea I realized that. It's a symlink which I assumed would be included if I directly exported from Alfred.

I'm updating the workflow lib at the same time. I'll push an update today

hehe that's a classic one. same thing for me when i develop a workflow.

Same error on init and debug?

so i guess you know by now but yes. had tested all commands, different modules needed but same error. hadn't check the source tho (busy coding!).

jeeftor commented 2 years ago

https://github.com/jeeftor/EmojiTaco/releases/tag/v2.0.1

Please let this be the one!

image
godbout commented 2 years ago

🙈ī¸

godbout commented 2 years ago

aww 😍ī¸

godbout commented 2 years ago

ok it didn't work the first time i've launched it. ran init emoji and let it download in the foreground. once it finished it went straight to ready, no parsing etc. tried again init emoji in the background (coz it worked with v2) and i got the notifications, everything got parsed and i can paste -> 🇨đŸ‡Ļī¸.

godbout commented 2 years ago

thank you! life is good again.

pat-s commented 2 years ago

Feedback on v2.0.2

init emoji seems to be stuck in a loop (quitted after 5 mins):

image

And I am still missing the preview thumbnails - but the copied emojies work and I can paste them 👍

jeeftor commented 2 years ago

Does "trying again" help at all for the init once it times out?

On Wed, Apr 6, 2022 at 10:08 AM Patrick Schratz @.***> wrote:

Feedback on v2.0.2

init emoji seems to be stuck in a loop (quitted after 5 mins):

[image: image] https://user-images.githubusercontent.com/8430564/162018687-1636dcad-2c2c-48d4-99f9-3f64d7ce88c3.png

And I am still missing the preview thumbnails - but the copied emojies work and I can paste them 👍

— Reply to this email directly, view it on GitHub https://github.com/jeeftor/EmojiTaco/issues/27#issuecomment-1090446930, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRQ4XYBA3YDWCZMEREQWYDVDWZHHANCNFSM5NFYRRVQ . You are receiving this because you were mentioned.Message ID: @.***>