search

jeeftor / intellifire_hacs

Intellifire Hacs Integration
0 stars 2 forks source link

Warnings on startup #1

Open manonstreet opened 5 months ago

manonstreet commented 5 months ago

The integration has been fairly stable since the v0.3.10 update. However the integration emits 2 warnings on start:

WARNING (MainThread) [custom_components.intellifire_hacs] Creating Data Update Coordinator and WARNING (MainThread) [custom_components.intellifire_hacs] async_forward_entry_setups

I'm not sure if this is expected?

manonstreet commented 5 months ago

Additional warning logged today. I've seen it before, I am unclear if its intermittent or a continual problem:

The custom integration 'intellifire' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

jeeftor commented 5 months ago

Last one is an easy fix Sent from my iPhoneOn Feb 7, 2024, at 4:00 PM, manonstreet @.***> wrote: Additional warning logged today. I've seen it before, I am unclear if its intermittent or a continual problem: The custom integration 'intellifire' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

jeeftor commented 5 months ago

I should have some time today to take a look at this... :)

Smashed my hand last week and today I can finally type again

jeeftor commented 5 months ago

image

So looks like there IS a version key in the codebase... I'll push a new release to make sure

(just pushed 0.3.11) let me know if its still an issue - not sure about the async setup issue however

manonstreet commented 5 months ago

Thanks @jeeftor. The version key error was sporadic. Has not re-surfaced recently.

On the async error, are you not seeing this as well? I consistently see it every time the intellifire is loaded. I can try uninstalling and reinstalling the integration.

And sorry to hear about your hand. Glad you are on the mend!

jeeftor commented 5 months ago

I'm copying code out of core, which doesn't have a version key so if I make a small mistake, the air will show up

jeeftor commented 5 months ago

I don't actually know if I get there because it just works when I use it. I should probably check.