search

jeelabs / jeelib

JeeLib for Arduino IDE: Ports, RF12, and RF69 drivers from JeeLabs
https://jeelabs.org/202x/sw/jeelib/
The Unlicense
490 stars 215 forks source link

Limit to one interrupt per rx packet #75

Closed JohnOH closed 9 years ago

JohnOH commented 9 years ago

This prevents multiple interrupts while draining the FIFO. If you are happy then please delete this donor branch.

JohnOH commented 9 years ago

I request that this pull request remains in play until @jcw decides its future.

jcw commented 9 years ago

As I understand it, the master branch has some problems in RF69_COMPAT mode. Is this part of it, anything else I could adopt from your RFxConsole branch or other to improve things?

JohnOH commented 9 years ago 
This one change will make a big improvement to master and has no
other dependencies. There are rather a lot of other changes, some
that aren't in your style and if you see any value in them perhaps
we could bring them into line with your house style. I am currently
tweaking classic RF69.cpp to pass native as well as classic packets.
Once I get that working perhaps we can diff master and that library
to get a list of what has changed and consider them point by point -
it has been a long time now and I don't recall all the changes
specifically.

On 31/05/2015 12:44, Jean-Claude
  Wippler wrote:

  As I understand it, the master branch has some problems in RF69_COMPAT
    mode. Is this part of it, anything else I could adopt from your
    RFxConsole branch or other to improve things?
  —
    Reply to this email directly or view
      it on GitHub.
jcw commented 9 years ago

Perfect, thanks - I'll merge this one in and close the issue. Please re-open or create a new one for further changes.