jeeliz / jeelizFaceFilter

Javascript/WebGL lightweight face tracking library designed for augmented reality webcam filters. Features : multiple faces detection, rotation, mouth opening. Various integration examples are provided (Three.js, Babylon.js, FaceSwap, Canvas2D, CSS3D...).
https://jeeliz.com
Apache License 2.0
2.68k stars 533 forks source link

Refactor the dependency #271

Closed dupasj closed 1 year ago

dupasj commented 2 years ago

Hello !

This is not to report a bug but to suggest you an improvement of your dependency. Are you interested by a big refactor of your dependency ? (I will include ThreeJS helper, within the core module in typescript. I never do some babylon project so I can't really do it :/)

I used twice our dependency, and I always copy/paste the projects files instead of use the package directly.

xavierjs commented 2 years ago

Hi @dupasj

Do you mean for the NPM package used in the https://github.com/jeeliz/jeelizFaceFilter/tree/master/reactThreeFiberDemo Or the static JavaScript demos?

dupasj commented 2 years ago

Hi @dupasj

Do you mean for the NPM package used in the https://github.com/jeeliz/jeelizFaceFilter/tree/master/reactThreeFiberDemo Or the static JavaScript demos?

Hi !

dupasj commented 2 years ago

I mean for the NPM package.

xavierjs commented 2 years ago

Sure I would be interested :) But I would prefer to keep Three.js helper either outside the package, or to put it in a separate package. Indeed, even if FaceFilter is mostly used with Three.js, this lib is framework agnostic.

dupasj commented 2 years ago

Yes sure ! It's what I want to do !

dupasj commented 2 years ago

Little outscoped question ^^' Will you provide more AR really experience ? Like foot tracking, body tracking, surface tracking... ?!

xavierjs commented 2 years ago
dupasj commented 2 years ago

Thus projects looks really cool ! Could I have the unminified source of the project ? I will try to merge all thus projects in one ;)

xavierjs commented 2 years ago

Hi,

The source code of the NPM package is here: https://github.com/jeeliz/jeelizFaceFilterNPMPackage But I don't provide the unmodified source code of the core of these projects.

dupasj commented 2 years ago

All right, I can't merge thus projects in one if I can't view the unminfied code, I will do my best. If you don't want to provide thus lines of code for reasons of fairness, we can sign confidentiality agreements if you want.

I send you an email with mores details. Cheers