jeertmans / manim-slides

Tool for live presentations using manim
https://manim-slides.eertmans.be
MIT License
489 stars 49 forks source link

[QUESTION] Are all dependencies needed for `manim-slides[magic]`? #393

Closed dmadisetti closed 8 months ago

dmadisetti commented 8 months ago

Please explain the issue you're experiencing (with as much detail as possible):

Is pyqt6 required for just the magics install? Just wondering if there's a working dependency subset

dmadisetti commented 8 months ago

Edit: according to the pytoml

jeertmans commented 8 months ago

Hello!

No, as you can see below, you do not need Qt bindings to use the magic feature. The same applies for the sphinx-directive feature.

https://github.com/jeertmans/manim-slides/blob/a85f1c40369428b7bd948e4b809308b4ca9ee26c/pyproject.toml#L58-L68

Does it answer your question? :-)

dmadisetti commented 8 months ago

qtpy is listed under deps though?

https://github.com/jeertmans/manim-slides/blob/a85f1c40369428b7bd948e4b809308b4ca9ee26c/pyproject.toml#L31

jeertmans commented 8 months ago

qtpy is listed under deps though?

https://github.com/jeertmans/manim-slides/blob/a85f1c40369428b7bd948e4b809308b4ca9ee26c/pyproject.toml#L31

Yep, but it does not require any Qt binding directly. I could hide put it behind a feature to remove it from the default dependencies, but it doesn’t matter much I think.

dmadisetti commented 8 months ago

No biggie, was just wondering how best to package this

jeertmans commented 8 months ago

But that was a great question! I might consider removing it for the next release