jeertmans / manim-slides

Tool for live presentations using manim
https://manim-slides.eertmans.be
MIT License
410 stars 44 forks source link

fix(lib): prevent filename collision #429

Closed jeertmans closed 1 month ago

jeertmans commented 2 months ago

Apparently, ManimCE can produce two different animations with the same name (i.e., the same hash). As documented, ManimGL would anyway produce files with the same name, so this fix was needed.

Closes #428

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.30%. Comparing base (962ff2b) to head (818f66b). Report is 1 commits behind head on main.

:exclamation: Current head 818f66b differs from pull request most recent head 19c74f6

Please upload reports for the commit 19c74f6 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #429 +/- ## ========================================== - Coverage 79.33% 79.30% -0.04% ========================================== Files 22 22 Lines 1815 1822 +7 ========================================== + Hits 1440 1445 +5 - Misses 375 377 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.