jeertmans / manim-slides

Tool for live presentations using manim
https://manim-slides.eertmans.be
MIT License
443 stars 48 forks source link

chore(lib): Remove old validation check preventing `loop=True` with `auto_next=True` #445

Closed mateuszdrwal closed 4 months ago

mateuszdrwal commented 4 months ago

Description

299 added support for stopping looping slides smoothly, at which point specifying both loop=True and auto_next=True on a next_slide starts making sense. There is an old validation check in the code referencing #299 that was never removed.

This functionality (on the next press, waiting for the current loop to end and then immediately proceeding to the next slide) seems to work without issues on the QT presenter. The reveal.js presenter doesn't like it as much, but it's also not supported by --next-terminates-loop.

Check List (Check all the applicable boxes)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.24%. Comparing base (9460f6b) to head (9f1d27d). Report is 25 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #445 +/- ## ========================================== - Coverage 79.30% 79.24% -0.07% ========================================== Files 22 22 Lines 1822 1816 -6 ========================================== - Hits 1445 1439 -6 Misses 377 377 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeertmans commented 4 months ago

Looks great, thanks!

jeertmans commented 4 months ago

Would you mind adding an entry to the CHANGELOG file?

mateuszdrwal commented 4 months ago

Yep, there you go

jeertmans commented 4 months ago

Yep, there you go

Many thanks!!