Closed mateuszdrwal closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.24%. Comparing base (
9460f6b
) to head (9f1d27d
). Report is 25 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks great, thanks!
Would you mind adding an entry to the CHANGELOG file?
Yep, there you go
Yep, there you go
Many thanks!!
Description
299 added support for stopping looping slides smoothly, at which point specifying both
loop=True
andauto_next=True
on anext_slide
starts making sense. There is an old validation check in the code referencing #299 that was never removed.This functionality (on the next press, waiting for the current loop to end and then immediately proceeding to the next slide) seems to work without issues on the QT presenter. The reveal.js presenter doesn't like it as much, but it's also not supported by
--next-terminates-loop
.Check List (Check all the applicable boxes)