jeertmans / manim-slides

Tool for live presentations using manim
https://manim-slides.eertmans.be
MIT License
489 stars 49 forks source link

fix(present): black video flashes and other bugs linked to Qt #465

Closed jeertmans closed 3 months ago

jeertmans commented 3 months ago

See #464 for original pull request. I did some mistakes but by pushing on my main branch instead of @PeculiarProgrammer 's main branch.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.83%. Comparing base (3b23c77) to head (0da32ad). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #465 +/- ## ========================================== - Coverage 80.54% 77.83% -2.72% ========================================== Files 22 22 Lines 1835 1827 -8 ========================================== - Hits 1478 1422 -56 - Misses 357 405 +48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

jeertmans commented 3 months ago

@PeculiarProgrammer: did you check that #315 was fixed on Windows?

PeculiarProgrammer commented 3 months ago

Yep. #315 was fixed.

jeertmans commented 3 months ago

Thanks @PeculiarProgrammer, I also ran some tests on Windows, both with PySide6 and PyQt6, and it worked (for PyQt6, I had to bump the minimal version, but looks good).