Should `Node.extract_subtree` return Tree, not seed node, & copy annotations?

jeetsukumaran / DendroPy

A Python library for phylogenetic scripting, simulation, data processing and manipulation.

https://pypi.org/project/DendroPy/.

BSD 3-Clause "New" or "Revised" License

210 stars 61 forks source link

Should `Node.extract_subtree` return Tree, not seed node, & copy annotations? #143

Open MordorianGuy opened 2 years ago

MordorianGuy commented 2 years ago

Hello,

There are two unexpected & confusing points about the method: firstly, it returns only the seed node, which is contrary to the name, secondly, it does not copy annotations.

What are the reasons for this behavior of the method? At least, parameters of coping might be optional.

Best regards,