Closed actapia closed 1 year ago
Good catch! Activated CI for this branch so we can test the change. Planning to add a regression test for this issue shortly to our unit test suite for this bug then merge and push a new release. Thanks for the PR!
Merging #170 (c57b7c5) into main (877a172) will increase coverage by
0.66%
. The diff coverage is100.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 60.75% 61.42% +0.66%
==========================================
Files 105 105
Lines 18646 18646
==========================================
+ Hits 11329 11453 +124
+ Misses 7317 7193 -124
Flag | Coverage Δ | |
---|---|---|
unittests | 61.42% <100.00%> (+0.66%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/dendropy/model/discrete.py | 76.43% <100.00%> (+56.54%) |
:arrow_up: |
Found another place where rng wasn't being passed!
A patch has been released as v.4.6.1
Thank you again for the contribution.
This change makes the
evolve_states
method ofDiscreteCharacterEvolver
pass itsrng
parameter toseq_model.simulate_descendant_states
.Before the change, this code results in an
AssertionError
:After this change, the assertion succeeds.