jeevatkm / ReplyWithHeader

Quoting Outlook style headers and Signatures for Mail.app
https://myjeeva.com/replywithheader
MIT License
64 stars 7 forks source link

Mojave support #115

Closed nicbedford closed 6 years ago

nicbedford commented 6 years ago

5.4 beta is not working on macOS 10.14 Mojave beta 1

jeevatkm commented 6 years ago

@nicbedford Thank you for the information. I will work on it.

By any chance if you have captured error info, could you post it here?

nicbedford commented 6 years ago

I'm not sure what error info you are after?

Install script appears to run correctly:

RWH:: Starting installation...
RWH:: Mail Plugin - ReplyWithHeader
RWH:: Mac OS X version: 10.14
RWH:: Mail.app 12.0 [Build 3445.100.9.7]

RWH:: Plugin is already installed, let's upgrade it
RWH:: user 'nbedford' is installing plugin
RWH:: Enabling plugin support in Mail.app
RWH:: Domain is /Users/nbedford/Library/Containers/com.apple.mail/Data/Library/Preferences/com.apple.mail.plist
RWH:: Adding UUID A4343FAF-AE18-40D0-8A16-DFAE481AF9C1
RWH:: Installation complete

=========================================================
  RWH Plugin successfully installed,  restart Mail.app   
=========================================================

But plugin is not loaded or shown in preferences when Mail.app is restarted, no error is displayed.

jeevatkm commented 6 years ago

Typically logs could be viewed via console.app and search option exists in that app.

I will start to setup Mojave at my end then investigate it, thanks.

nicbedford commented 6 years ago

I did check Console.app and searched for ReplyWithHeader, it showed nothing

jeevatkm commented 6 years ago

Thank you @nicbedford. I missed to mention details of enabling debug. Could you please try one more time after this setting on terminal app?

Enable debug log:

defaults write com.apple.mail MHDebugLog -bool true

Disable debug log:

defaults write com.apple.mail MHDebugLog -bool false

PS: If nothings turns up, that is fine. Thank you for your effort. I will take care once my environment is ready.

jeevatkm commented 6 years ago

My subscription is expired. I'm not planning to renew for while. It seems I will have to wait for public beta release date 🤔.

jeevatkm commented 6 years ago

Mojave new security model completely hindering development of plugin and plenty of API changes happen :(

jeevatkm commented 6 years ago

Good news, found the issues on Mojave 😄

Its mainly related to explicit permission model introduced by Apple in Mojave OS. I will fix (or create a document how to install it) and make a release.

jeevatkm commented 6 years ago

@nicbedford I need help in testing the v5.4 beta version of plugin.

Could please install v5.4-beta on Mojave OS using following steps and share your feedback?

Now RWH should be working.

Please let me know.

nicbedford commented 6 years ago

I can see RWH in the Mail-> Preferences -> General Tab -> Manage Plug-ins. But after I enable it and restart it loads the plugin and then pops up a dialog saying not compatible with Mail v12 and then immediately unloads.

screenshot 2018-09-21 07 18 07
jeevatkm commented 6 years ago

@nicbedford Thank you. I believe its related to plugin UUID part. I will make a respective change and get back to you.

BTW, could you please share the output of sudo ./Install-or-Upgrade-or-Reenable.command?

nicbedford commented 6 years ago
RWH:: Starting installation...
RWH:: Mail Plugin - ReplyWithHeader
RWH:: Mac OS X version: 10.14
RWH:: Mail.app 12.0 [Build 3445.100.39]

RWH:: Plugin is already installed, let's upgrade it
RWH:: Root users is installing plugin
RWH:: Domain is /Users/root/Library/Preferences/com.apple.mail.plist
RWH:: Adding UUID A4343FAF-AE18-40D0-8A16-DFAE481AF9C1
RWH:: Applying appropriate file permission for user 'nbedford'
RWH:: Installation complete

=========================================================
  RWH Plugin successfully installed,  restart Mail.app   
=========================================================
jeevatkm commented 6 years ago

Thank you @nicbedford

mshahat commented 6 years ago

waiting for that, as soon as possible please ...

markcarroll commented 6 years ago

This is still not working for me.

> sudo ./Install-or-Upgrade-or-Reenable.command

RWH:: Starting installation...
RWH:: Mail Plugin - ReplyWithHeader
RWH:: Mac OS X version: 10.14
RWH:: Mail.app 12.0 [Build 3445.100.39]

RWH:: Plugin is already installed, let's upgrade it
rm: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle: Operation not permitted
cp: ./ReplyWithHeader.mailbundle: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/MacOS: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/MacOS: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/MacOS/ReplyWithHeader: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/de.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/de.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/de.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/de.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/en.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/MHPreferencesView.nib: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/MHUpdateAlert.nib: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/MHPreferencesView.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/MHDisplayNotes.nib: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/bitcoin-24.png: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/es.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/es.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/es.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/es.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/it.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/it.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/it.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/it.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Entitlements.plist: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ReplyWithHeader.icns: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Credits.rtf: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/btn_donate_pp_142x27.png: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/language.png: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/LICENSE.txt: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Info.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Icon\r: Operation not permitted
RWH:: Root users is installing plugin
RWH:: Enabling plugin support in Mail.app
RWH:: Domain is /Library/Preferences/com.apple.mail.plist
RWH:: Adding UUID A4343FAF-AE18-40D0-8A16-DFAE481AF9C1
2018-10-01 09:54:41.288 defaults[23989:7366107] Could not write domain /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Info.plist; exiting
RWH:: Applying appropriate file permission for user 'mark'
chown: /Users/mark/Library/Mail/Bundles: Operation not permitted
chown: /Users/mark/Library/Mail/Bundles: Operation not permitted
chmod: /Users/mark/Library/Mail/Bundles: Operation not permitted
RWH:: Installation complete

=========================================================
  RWH Plugin successfully installed,  restart Mail.app   
=========================================================
jeevatkm commented 6 years ago

@markcarroll Thanks for the log and error info.

Technically I have made v6.0-beta work with Mojave OS (last weekend). However I have not yet found a best way sort out permission issue and RWH preference UI cut (outstanding issue).

Mojave OS really giving me hard time 😢

jeevatkm commented 6 years ago

@nicbedford @mshahat @markcarroll I have prepared RWH v6.0-beta http://bit.ly/2E61TID

Archive include install instructions Install-Instructions-Mojave-OS-and-Above.txt. Could you please try and let me know if any thing broken?

FYI, RWH preferences moved to Mail.app menu bar under RWH menu.


After I collect the good no. of user feedbacks then I will do clean up and final changes for v6.0 release next week.

Daskarzine commented 6 years ago

Thanks Jeeva - working for me!! Yay!

jeevatkm commented 6 years ago

@Daskarzine Thanks for your confirmation. Give it a try few days, please do let me know if any issues. I will fix it in v6.0 release.

plusmore57 commented 6 years ago

Works great for me. Thanks for putting in the hard work.

nicbedford commented 6 years ago

I follow all steps and I still get Incompatible Plug-ins Disabled dialog as shown above :(

zmbarry commented 6 years ago

Works for me too. I can not see the RWH preferences pane but replying to email inserts the Outlook-style header. Thank you!

jeevatkm commented 6 years ago

@nicbedford

Incompatible Plug-ins Disabled dialog

If you're getting dialog, it means you're facing an permission issue or UUID is not getting added to RWH plist.

Could you delete existing RWH plugin from ~/Library/Mail/Bundles manually (if any)? Then apply the steps from Install-Instructions-Mojave-OS-and-Above.txt.

I'm expecting v6.0-beta should work with Mojave OS. I may be expecting some other hiccups since a lot of internal improvements has been done in v6.0-beta.

jeevatkm commented 6 years ago

@zmbarry RHW preferences moved to main menu. You should be seeing RWH menu in the menu bar.

nicbedford commented 6 years ago

I have it working now. I was running the Install-or-Upgrade-or-Reenable.command from terminal (I had definitely restarted after adding FullDiskAccess permission).

I now just double clicked Install-or-Upgrade-or-Reenable.command instead and it worked.

I don't understand, but I'm happy

jeevatkm commented 6 years ago

@nicbedford Glad to hear, its working for you. Keep me posted if you notice any issues.

BonnEconLab commented 6 years ago

The v6 beta works for me, too (on macOS Mojave, Mail v12.0; also on macOS High Sierra, Mail v11.5). A great many thanks for this helpful plug-in!

mttransplant commented 6 years ago

The v6 beta seems to be working for me as well. Thank you!

gcabanac commented 6 years ago

The v6.0-beta works like a charm on macOS Mojave, Mail v12.0. Thanks!

in4philo commented 6 years ago

It works like a charm ! Thanks a lot Jeeva !!

markcarroll commented 6 years ago

Install worked out fine once I actually followed the instructions. ;)

There is a typo on the preferences pane: "Include header bule line" https://github.com/jeevatkm/ReplyWithHeader/commit/181f41e29620874901f904f078cdb25bc2a60a62#r30974313

jeevatkm commented 6 years ago

@markcarroll Oops! I will correct it. Yesterday I added that new option.

jeevatkm commented 6 years ago

I have released RWH v6.0 just now 😄

AlainCallebaut commented 6 years ago

On MacOS Mojave 10.14.1, using ReplyWithHeader v6-2.0: Incompatible Plug-ins Disabled Contact the makers for versions that are compatible with Mail 12.1

jeevatkm commented 6 years ago

@AlainCallebaut On every macOS release Mail.app gets a new UUID. All you have to do is. Just reinstall RWH plugin, it will work.

AlainCallebaut commented 6 years ago

I did reinstall it. Even uninstalled and installed again. It gives me the same error message...

On 20 Nov 2018, at 22:19, Jeevanandam M. notifications@github.com wrote:

@AlainCallebaut https://github.com/AlainCallebaut On every macOS release Mail.app gets a new UUID. All you have to do is. Just reinstall RWH plugin, it will work.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jeevatkm/ReplyWithHeader/issues/115#issuecomment-440433073, or mute the thread https://github.com/notifications/unsubscribe-auth/ArHn-SiH20eZ-gRQfzRkUktxaySyr_3Aks5uxHHUgaJpZM4UhZyP.

jeevatkm commented 6 years ago

@AlainCallebaut Its strange I'm using 10.14.1 too with RWH plugin on it. It's doing good.

So you have followed the steps from Install-Instructions-Mojave-OS-and-Above.txt and still you're getting an error?

AlainCallebaut commented 6 years ago

Yes I did. Finally I found the cause of the problem, and a work around. It seems that the security of Mojave is completely screwed. Your script performs a 'defaults write' to add the UUID. However, due to security restrictions, the plist is not updated. When editing the plist manually (with XCode, after assigning XCode FullDiskAccess) and adding that key and value, it works as expected. I added /usr/bin/defaults to the FullDiskAccess but that didn't let your script update the plist. So there remains a serious problem to perform such installation through a script...

jeevatkm commented 6 years ago

@AlainCallebaut Thanks for the update.

Did you provide Terminal.app (or iterm.app whichever you're using) FullDiskAccess and still UUID is not updated in the plist? If yes I have to investigate this part of issue, please confirm.

Basically installer adds UUID in to RWH plist before it installs a plugin into ~/Library/Mail/Bundles.

AlainCallebaut commented 6 years ago

Yes I did. I used the Terminal.app. Here is a screenshot of the Security settings (don't know if it will show up).

screenshot 2018-11-21 at 20 41 29
jeevatkm commented 6 years ago

@AlainCallebaut Thank you for your confirmation. I will investigate this issue.

indirection commented 5 years ago

Thank you.