jeevatkm / ReplyWithHeader

Quoting Outlook style headers and Signatures for Mail.app
https://myjeeva.com/replywithheader
MIT License
64 stars 7 forks source link

macOS Catalina Support #123

Open markcarroll opened 5 years ago

markcarroll commented 5 years ago

Upgraded to MacOS Catalina Beta 2, ran the usual upgrade path (terminal command etc) but this time it did not work.

$ ~/Downloads/ReplyWithHeader-v6.1/Install-or-Upgrade-or-Reenable.command 

RWH:: Starting installation...
RWH:: Mail Plugin - ReplyWithHeader
RWH:: Mac OS X version: 10.15
2019-07-01 21:50:44.173 defaults[4249:77165] 
The domain/default pair of (/Applications/Mail.app/Contents/Info, CFBundleShortVersionString) does not exist
2019-07-01 21:50:44.224 defaults[4250:77168] 
The domain/default pair of (/Applications/Mail.app/Contents/Info, CFBundleVersion) does not exist
RWH:: Mail.app  [Build ]
RWH:: user '<...>' is installing plugin
RWH:: Enabling plugin support in Mail.app
RWH:: Domain is /Users/<...>/Library/Containers/com.apple.mail/Data/Library/Preferences/com.apple.mail.plist

RWH:: Plugin is already installed, let's upgrade it
RWH:: Installation complete

=========================================================
  RWH Plugin successfully installed,  restart Mail.app   
=========================================================

It looked fine, however when I go to the Mail Plugins section in the settings to enable, there is nothing there.

Screen Shot 2019-07-01 at 9 55 37 PM
jeevatkm commented 5 years ago

@markcarroll Thank you for reporting an issue. I will look into the OS Catalina issue. Currently, I have not yet prepared the beta OS, will do it.

markcarroll commented 5 years ago

Update on Dev Beta 5.

Running with sudo ./Install-or-Upgrade-or-Reenable.command did not work:

RWH:: Starting installation...
RWH:: Mail Plugin - ReplyWithHeader
RWH:: Mac OS X version: 10.15
2019-08-05 10:10:36.370 defaults[7745:1024769] 
The domain/default pair of (/Applications/Mail.app/Contents/Info, CFBundleShortVersionString) does not exist
2019-08-05 10:10:36.385 defaults[7746:1024772] 
The domain/default pair of (/Applications/Mail.app/Contents/Info, CFBundleVersion) does not exist
RWH:: Mail.app  [Build ]
RWH:: Root users is installing plugin
RWH:: Domain is /Users/root/Library/Preferences/com.apple.mail.plist

RWH:: Plugin is already installed, let's upgrade it
rm: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle: Operation not permitted
cp: ./ReplyWithHeader.mailbundle: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/MacOS: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/MacOS: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/MacOS/ReplyWithHeader: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/de.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/de.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/de.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/de.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hans.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ja.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/en.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/uk.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/bitcoin-24.png: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nb.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/en-GB.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en-GB.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en-GB.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en-GB.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/es.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/es.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/es.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/es.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/it.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/it.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/it.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/it.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Entitlements.plist: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/sv.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ko.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj/MHPreferences.nib: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj/MHUpdateAlert.nib: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj/MHDisplayNotes.nib: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Base.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/zh-Hant.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ReplyWithHeader.icns: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/Credits.rtf: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/btn_donate_pp_142x27.png: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-BR.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/ru.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/en-US.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en-US.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en-US.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/en-US.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/language.png: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/fr.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/nl.lproj/MailHeader.strings: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/LICENSE.txt: Operation not permitted
cp: ./ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj: unable to copy extended attributes to /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj/Config.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Resources/pt-PT.lproj/MailHeader.strings: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Contents/Info.plist: Operation not permitted
cp: /Users/mark/Library/Mail/Bundles/ReplyWithHeader.mailbundle/Icon\r: Operation not permitted
RWH:: Applying appropriate file permission for user 'mark'
chown: /Users/mark/Library/Mail/Bundles: Operation not permitted
chown: /Users/mark/Library/Mail/Bundles: Operation not permitted
chmod: /Users/mark/Library/Mail/Bundles: Operation not permitted
RWH:: Installation complete

=========================================================
  RWH Plugin successfully installed,  restart Mail.app   
=========================================================

However, if I sudo -I and then install, it seems to go through:

RWH:: Starting installation...
RWH:: Mail Plugin - ReplyWithHeader
RWH:: Mac OS X version: 10.15
2019-08-05 10:13:36.621 defaults[9047:1028090] 
The domain/default pair of (/Applications/Mail.app/Contents/Info, CFBundleShortVersionString) does not exist
2019-08-05 10:13:36.641 defaults[9048:1028093] 
The domain/default pair of (/Applications/Mail.app/Contents/Info, CFBundleVersion) does not exist
RWH:: Mail.app  [Build ]
RWH:: '/var/root/Library/Mail/Bundles' directory not exists, creating one
RWH:: Root users is installing plugin
RWH:: Domain is /Users/root/Library/Preferences/com.apple.mail.plist

RWH:: Installing ReplyWithHeader Mail plugin
RWH:: Applying appropriate file permission for user 'root'
RWH:: Installation complete

=========================================================
  RWH Plugin successfully installed,  restart Mail.app   

However, once I run Mail.app I get a warning saying the plug-in is not compatible. It does now show up in the plugin list but won't run due to the compatibility issue.

Getting closer...

versteegh commented 5 years ago

The RHW plugin will load. I tested it on a clean Dev Beta5 install.

Add/Change the following lines in the Install-or-Upgrade-or-Reenable.command:

mh_mail_version=$(defaults read /System/Applications/Mail.app/Contents/Info CFBundleShortVersionString)

mh_mail_build_version=$(defaults read /System/Applications/Mail.app/Contents/Info CFBundleVersion)

if [ -f /System/Applications/Mail.app/Contents/Info.plist ]; then

mh_mail_app_uuid=$(defaults read /System/Applications/Mail.app/Contents/Info.plist PluginCompatibilityUUID)

add this after line 77: if [[ ${mh_mac_osx_version_p} == *"10.15"* ]]; then defaults write "${mh_plugin_plist}" Supported10.15PluginCompatibilityUUIDs -array-add "${mh_mail_app_uuid}" change the if statement on next line into elif: elif [[ ${mh_mac_osx_version_p} == *"10.14"* ]]; then

and lastly around line 129: if [[ ${mh_mac_osx_version_p} == *"10.1"[4..5]* ]]; then

Build the mailbundle with XCode and ignore the copy error from the last command in the script in the Build phase: "Bundle Packing and Deploy Local".

In order to get the bundle picked up and installed by the Install-or-Upgrade-or-Reenable.command script, move the created mail bundle from the <...>/Build/Products/Debug/ folder to the Misc folder and make a last change in the script to the copy command around line 114. Change it to yes | cp -rf "ReplyWithHeader.mailbundle" "${mh_install_path}"

markcarroll commented 5 years ago

Thanks for the detailed response. However this still doesn't work for me. Still the version error. I will keep playing with it.

jeevatkm commented 5 years ago

Start preparing OS Catalina for RWH development.

markcarroll commented 5 years ago

Any update? I tried your new install script on the Catalina GM and while it did install without error, I get an incompatible error when turning on the extension in the Mail.app UI

thwinkle commented 5 years ago

I would also love to use it again in Catalina - missing this a lot. Happy to help with testing

gcabanac commented 5 years ago

Me too: I'm available for testing on Catalina as you see fit :)

markcarroll commented 5 years ago

I managed to get a build working and load this into Mail.app on Catalina, but now reply and forwards fail with this error:

Mail    -[HeadersEditor bringOutlookReplyAllBehaviour]: unrecognized selector sent to instance 0x7fa36d5086b0
jeevatkm commented 5 years ago

@markcarroll yeah, I have sorted out the installation script for Catalina os many weeks ago, After that I ran into Apple's Mail.app internal APIs changes. Honestly it seems apple did an overhaul in the mail app internals; many many changes, so far I did not find an appropriate APIs to integrate RWH yet. That's why you're getting an error -

unrecognized selector sent to instance
mshahat commented 4 years ago

Hello, what's the latest on this, please?

grifjef commented 4 years ago

I love this plugin. Is there any hope for a fix on Catalina?

renelauzon commented 4 years ago

I too love the plugin. It seems the "Forward" function carries the header information correctly, it's just the "Reply" that no longer functions. Any updates on when the Catalina compatible version will be available? Happy to donate $ to the cause.

renelauzon commented 4 years ago

@jeevatkm - please do let us all know if you're "officially" dropping this plugin from your supported pieces of work. It has worked wonderfully for so long until Catalina "broke" it. Seems so close with the forwarding feature still having the header, yet reply nothing. Again, no problem for me making a donation to the cause....just would like to know either way. Thank you again for all your past work

jeevatkm commented 4 years ago

@renelauzon and dear users -

I have not given up yet

Due apple extensive internal API changes giving me hard time. Also, my work is a bit hectic too. I'm trying to catch whenever I get time.

I appreciate your interest and support. Thank you.

FYI, #126

dgrenier commented 4 years ago

I'd also like to see RWH support Catalina. I've been using it for a few months on Mojave and it's been great.

sterid commented 4 years ago

Hi, No news for Catalina? May be it possible to fix in Big Sur?

markcarroll commented 4 years ago

Hi @jeevatkm are you still working on this project? Big Sur is almost here and we didn't see a Catalina update. I miss your plug-in. 😄

renelauzon commented 4 years ago

Hi @jeevatkm - we all still miss this lovely feature so much! Please give us all a hint as to how this goes and if you're work level will afford you any cycles here.

jeevatkm commented 4 years ago

@markcarroll, @renelauzon, @dgrenier, @sterid - Thanks for checking it. I'm really very sorry for the inconvenience. Apple really did big changes under the hood plus the new permission model. Its been many months I did not work on this; also due to COVID (work from home), my work hours are really messed up.

I will try to catch up and also I will look at Big Sur too to see; whether Apple kept any openings on Mail.app.

Daskarzine commented 4 years ago

Thanks Jeeva, it would be great to know either way!

RMaxCt commented 4 years ago

Jeeva, thanks for this great plugin. I found ReplyWithHeader when I was working in a legal environment and maintaining the header info in a standard and clear format was critical for using Mac Mail in this environment.

I look forward to being able to use ReplyWithHeader again in the future.

GHubbler commented 4 years ago

macOS Big Sur is out. So I'd like to ask, if there's any hope or plans to support it.

128

sterid commented 3 years ago

Did anyone found working API for RWH in Big Sur?