jeevatkm / ReplyWithHeaderMozilla

Outlook style headers and few goodies for Thunderbird
https://myjeeva.com/replywithheader-mozilla
Mozilla Public License 2.0
46 stars 22 forks source link

Add support for TB 68.0 #88

Closed jeevatkm closed 4 years ago

jeevatkm commented 5 years ago

The goal of this issue to identify the necessary updates required for RWH to make it work in TB 68.0

Please Note: I have to learn and perform this upgrade, it might take a while due to my day work commitments. However, I will surely add support :smile:

jeevatkm commented 5 years ago

Collected notes:

wikiaal commented 5 years ago

Please, give support. I had to go back to TB 60.9.0 because your add-on doesn't work with TB 68.0.

WesleyGeneroso95 commented 5 years ago

+1 Please, give support to the TB 68.0.

FxRe commented 5 years ago

People, he already announced that he's working on it. I don't think it'll go any faster, if you just reply "Please, give support"... If you want it so badly, you'll have to be more productive.

wikiaal commented 5 years ago

People, he already announced that he's working on it. I don't think it'll go any faster, if you just reply "Please, give support"... If you want it so badly, you'll have to be more productive.

Thunderbird 68 had been published in beta for 2 months ... maybe think about it a little earlier ...

FxRe commented 5 years ago

Thunderbird 68 had been published in beta for 2 months ... maybe think about it a little earlier...

Even if it had been published 2 decades ago, that doesn't make a difference at all right now.

jeevatkm commented 5 years ago

@FxRe Thank you for your understanding and support.

@wikiaal Thanks for sharing your concerns. From RWH user standpoint, it's very valid.

I want to share my situation and perspective. I love doing open-source projects and do my best with my limited time along with day work, family, personal, etc. So, I wait until the final version comes out. Then I search for documentation for changes needs to performed, sometimes due to unavailable documentation; I have to take an additional step to learn from fellow add-on developers by reverse engineering.

Spicy on Top: The past couple of years TB has been releasing quite no. of breaking changes and its good for TB roadmap but it brings challenges to add-on developers. Also, TB has very very limited documentation in these scenarios.

I kindly request you to recognize that fact and provide support.

wikiaal commented 5 years ago

If you need someone to make tests with upcoming RWH for TB v68 please ask.

insekt commented 5 years ago

Please add support for Thunderbird 68. I'm in 1 step from switching to Outlook =(

dpate71 commented 5 years ago

Any news on RWH compatibility for TB 68?

athanas55 commented 5 years ago

Please add support for Thunderbird 68. I'm in 1 step from switching to Outlook =(

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

insekt commented 5 years ago

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

@athanas55 Could you point me to that plugin?

jeevatkm commented 5 years ago

Hello All -

I have created a working version RWH v2.2.0-beta addon for TB 68 plus version. However, there is an issue yet be sorted out is RWH preferences (no errors, needs investigation).

Download link: http://bit.ly/2MFswW5

In the meantime, can you please try and share your feedback.

Cheers, Jeeva

wikiaal commented 5 years ago

Dear Jeeva, thank you very much for your work!!! I've just upgraded (in my secondary laptop) to TB 68.1.2 and installed RWH 2.2 beta. I'll send you a feedback a.s.a.p.

jeevatkm commented 5 years ago

@wikiaal Thank you for your help, appreciated 👍

wikiaal commented 5 years ago

Dear Jeeva, first test with TB 68.1.2: the RWH 2.2.beta seems to work properly for mail reply and forward, but I have no access to RWH settings (I see only deactivate and remove buttons, no settings button anywhere).

insekt commented 5 years ago

@jeevatkm thank you very much! @wikiaal confirm the same behaviour.

zdenekvecera commented 5 years ago

@jeevatkm, thank you very much!

ghost commented 5 years ago

WFM with 70.0b3 (64-bit) on WIN 10 Pro v1903 x_64, except no settings to access.


Just thought to mention about the display of settings:

This MX (mail extension) https://mailredirect.sourceforge.io for example integrates its settings with the main Options -> Composition UI

Annotation 2019-10-15 123509

Whilst this one https://github.com/lieser/dkim_verifier features its own tab

Annotation 2019-10-15 123509

WesleyGeneroso95 commented 5 years ago

Dear Jeeva, I'm testing the plugin with TB 68.1.2 and everythings seems to work great.

athanas55 commented 5 years ago

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

@athanas55 Could you point me to that plugin?

@insekt Try searching for SmartTemplate4

wikiaal commented 5 years ago

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

@athanas55 Could you point me to that plugin?

@insekt Try searching for SmartTemplate4

SmartTemplate4 is more complex (and less reliable) to use than RWH and isn't free.

m-i-k-e-y commented 5 years ago

@jeevatkm: The beta you provided is working for me. Thank you!

This is the only thing I've found in the error console related to this extension:

1571159586588 addons.webextension.replywithheader@myjeeva.com WARN Loading extension 'replywithheader@myjeeva.com': Reading manifest: Error processing xpi-name: An unexpected property was found in the WebExtension manifest.

alphp commented 5 years ago

@jeevatkm thank you very much! @wikiaal confirm the same behaviour.

jeevatkm commented 5 years ago

Thank you @wikiaal, @zdenekvecera, @insekt, @WesleyGeneroso95, @m-i-k-e-y, @alphp for trying out and sharing your feedback.

Once I sort out the implementation of the RWH settings, I will make a few more beta releases to ensure everything works then I will do a final release.


I want to provide internal details of TB and its roadmap. How it's affecting the addons.

Since TB 68 addon model is changed to WebExtension/MailExtension. all the changes I'm doing will be good until version TB 78. So a permanent solution is to rewrite the RWH addon into the WebExtension model. I will learn and do it later on.

jeevatkm commented 5 years ago

Hello All -

I have prepared the next beta version with RWH preferences issues fixed. Can you please test it out and provide your feedback?

Download link: http://bit.ly/2BtWMOx

I will wait for couple of weeks, If everything working alright then I will bump the release version to v3.0.0 and I will submit it to AMO.

Cheers, Jeeva

wikiaal commented 5 years ago

Hi Jeeva, first of all thank you very much for the work done!!!

Just tested the new RWH v2.2.1-beta with a clean Thunderbird 68.1.2 installation:

With my best regards Andrea

jeevatkm commented 5 years ago

Hello Andrea - Thank you for your feedback.

Cheers, Jeeva

zdenekvecera commented 5 years ago

@jeevatkm, thank you very much.

I couldn't change my settings in a previous beta. But in this new RWH v2.2.1-beta the settings works again. Great!

m-i-k-e-y commented 5 years ago

@jeevatkm Thanks again. Settings do open for me and seem to work so far.

The error message I've seen with the previous beta is gone too in the error console, only this warning is left:

Ignoring unrecognized chrome manifest directive 'overlay'. chrome.manifest:16

That points to this line in the manifest of your addon:

overlay chrome://messenger/content/messengercompose/messengercompose.xul chrome://replywithheader/content/messengerComposeOverlay.xul

Keep up the good work!

wikiaal commented 5 years ago

Okay, I've found RWH "Settings": Tools > Addon Options > ReplyWithHeader.

Thank you very much!!! Andrea

tidebre67 commented 5 years ago

Jeeva, as far as i can see RWH v2.2.1-beta works really fine.

many tks

ghost commented 5 years ago

Hi Jeeva,

reply and forward work properly. Preferences are not being displayed under Tools>Add-on Preferences. Tried it a couple of times. I won´t give up! ;)

EDIT: Got the preferences! I searched in the wrong place!

Thank you very much for your work!

wikiaal commented 5 years ago

Hi Jeeva, after some more tests, I've found an issue with RWH: replying to some mails, with "Forward" I have the original body with the same format of the header (body text, font), with "Reply" the body format becomes different (preformatted?) with plain fixed lenght font, while the header remains as with "Forward".

athanas55 commented 5 years ago

Hello Jeeva Just installed the beta and its performing as it should until now. System: W10, 64bit, v.1903, TB: 68.2.0, 64bit. In case any bugs come up I'll report them here. Thank you for your efforts and dedication to open-source projects.

Thanos

jc97 commented 4 years ago

Hello,

I tried the beta version too and it is working perfectly for me. I think you can bump the release.

Thanks!

netjeff commented 4 years ago

Just found this thread. Installed the beta, and works perfectly. Looking forward to the official release. Thanks @jeevatkm! I just donated, hopefully lots of people will donate for your great work.

jeevatkm commented 4 years ago

Dear All - FYI, RWH v2.2.1 release version submitted to AMO for approval.

wikiaal commented 4 years ago

Hi Jeeva, thank you so much for your invaluable work, look forward for final 2.2.1 version of RWH.

With my best regards Andrea

jeevatkm commented 3 years ago

Hello @wikiaal - I'm wondering. is these are your reviews? if yes, do you mind updating the review and stars?

https://addons.thunderbird.net/en-US/thunderbird/addon/replywithheader/reviews/user:13652970

Regards, Jeeva