jef / streetmerchant

🤖 The world's easiest, most powerful stock checker
https://jef.buzz/streetmerchant
MIT License
4.97k stars 1.3k forks source link

In stock 3060tis arent getting shown within our price range. #2035

Closed calwe closed 3 years ago

calwe commented 3 years ago

Expected Behavior

All 3060tis, whether in our price range or not, should be listed.

Current Behavior

Only 3060tis above our max price are being shown, and notifications aren't being sent (such as through discord webhooks)

Steps to Reproduce

Set it to scan for 3060tis. Set MAX_PRICE_SERIES_3060TI to any value.

Only 3060tis that cost more than this MAX_PRICE will be displayed in the format: PRICE 410 EXCEEDS LIMIT 300

Environment

# ** All configuration variables are optional **
# Copy this file and name it as `dotenv` (without backticks)
# Read https://jef.codes/streetmerchant/getting-started/#customization for help on customizing this file
########################################################################################################

ASCII_BANNER=
ASCII_COLOR=
AUTO_ADD_TO_CART=
BROWSER_TRUSTED=
COUNTRY=
DESKTOP_NOTIFICATIONS=
DISCORD_NOTIFY_GROUP=
DISCORD_NOTIFY_GROUP_3060TI=
DISCORD_NOTIFY_GROUP_3070=
DISCORD_NOTIFY_GROUP_3080=
DISCORD_NOTIFY_GROUP_3090=
DISCORD_NOTIFY_GROUP_CORSAIR_SF=
DISCORD_NOTIFY_GROUP_RX6800=
DISCORD_NOTIFY_GROUP_RX6800XT=
DISCORD_NOTIFY_GROUP_RX6900XT=
DISCORD_NOTIFY_GROUP_RYZEN5600=
DISCORD_NOTIFY_GROUP_RYZEN5800=
DISCORD_NOTIFY_GROUP_RYZEN5900=
DISCORD_NOTIFY_GROUP_RYZEN5950=
DISCORD_NOTIFY_GROUP_SONYPS5C=
DISCORD_NOTIFY_GROUP_SONYPS5DE=
DISCORD_NOTIFY_GROUP_XBOXSX=
DISCORD_NOTIFY_GROUP_XBOXSS=
DISCORD_NOTIFY_GROUP_TEST=
DISCORD_WEB_HOOK=
EMAIL_PASSWORD=
EMAIL_TO=
EMAIL_USERNAME=
HEADLESS=
IN_STOCK_WAIT_TIME=
LOG_LEVEL=
LOW_BANDWIDTH=
MAX_PRICE_SERIES_3060TI=420
MAX_PRICE_SERIES_3070=
MAX_PRICE_SERIES_3080=
MAX_PRICE_SERIES_3090=
MAX_PRICE_SERIES_CORSAIR_SF=
MAX_PRICE_SERIES_RX6800=
MAX_PRICE_SERIES_RX6800XT=
MAX_PRICE_SERIES_RX6900XT=
MAX_PRICE_SERIES_RYZEN5600=
MAX_PRICE_SERIES_RYZEN5800=
MAX_PRICE_SERIES_RYZEN5900=
MAX_PRICE_SERIES_RYZEN5950=
MAX_PRICE_SERIES_SONYPS5C=
MAX_PRICE_SERIES_SONYPS5DE=
MAX_PRICE_SERIES_XBOXSS=
MAX_PRICE_SERIES_XBOXSX=
MAX_PRICE_SERIES_TEST=
MICROCENTER_LOCATION=
MQTT_BROKER_ADDRESS=
MQTT_BROKER_PORT=
MQTT_CLIENT_ID=
MQTT_PASSWORD=
MQTT_QOS=
MQTT_TOPIC=
MQTT_USERNAME=
NVIDIA_ADD_TO_CART_ATTEMPTS=
NVIDIA_SESSION_TTL=
OPEN_BROWSER=
PAGE_BACKOFF_MIN=
PAGE_BACKOFF_MAX=
PAGE_SLEEP_MIN=
PAGE_SLEEP_MAX=
PAGE_TIMEOUT=
PAGERDUTY_INTEGRATION_KEY=
PAGERDUTY_SEVERITY=
PHILIPS_HUE_API_KEY=
PHILIPS_HUE_CLOUD_ACCESS_TOKEN=
PHILIPS_HUE_CLOUD_CLIENT_ID=
PHILIPS_HUE_CLOUD_CLIENT_SECRET=
PHILIPS_HUE_CLOUD_REFRESH_TOKEN=
PHILIPS_HUE_LAN_BRIDGE_IP=
PHILIPS_HUE_LIGHT_COLOR=
PHILIPS_HUE_LIGHT_IDS=
PHILIPS_HUE_LIGHT_PATTERN=
PHONE_CARRIER=
PHONE_NUMBER=
PLAY_SOUND=/data/MiningRig/StockFinder/NICE.mp3
PROXY_ADDRESS=
PROXY_PROTOCOL=
PROXY_PORT=
PUSHBULLET=
PUSHOVER_EXPIRE=
PUSHOVER_RETRY=
PUSHOVER_TOKEN=
PUSHOVER_USER=
PUSHOVER_PRIORITY=
SCREENSHOT=
SHOW_ONLY_BRANDS=
SHOW_ONLY_MODELS=
SHOW_ONLY_SERIES=3060ti
SLACK_CHANNEL=
SLACK_TOKEN=
SMTP_ADDRESS=
SMTP_PORT=
STORES=amazon-uk,amd-uk,box,ccl,awd,currys,ebuyer,game,johnlewis,novatech,overclockers,scan,shopto,smythstoys,very
TELEGRAM_ACCESS_TOKEN=
TELEGRAM_CHAT_ID=
TWILIO_ACCOUNT_SID=
TWILIO_AUTH_TOKEN=
TWILIO_FROM_NUMBER=
TWILIO_TO_NUMBER=
TWITCH_ACCESS_TOKEN=
TWITCH_CHANNEL=
TWITCH_CLIENT_ID=
TWITCH_CLIENT_SECRET=
TWITCH_REFRESH_TOKEN=
TWITTER_ACCESS_TOKEN_KEY=
TWITTER_ACCESS_TOKEN_SECRET=
TWITTER_CONSUMER_KEY=
TWITTER_CONSUMER_SECRET=
TWITTER_TWEET_TAGS=
WEB_PORT=

Logs

> start
> npm run compile && node build/src/index.js

> compile
> tsc

STREETMERCHANT
3.4.1

[07:02:05] info :: ℹ selected stores: amazon-uk, amd-uk, box, ccl, awd, currys, ebuyer, game, johnlewis, novatech, overclockers, scan, shopto, smythstoys, very
[07:02:05] info :: ℹ selected series: 3060ti
[07:02:06] info :: ✔ sound player found: mpg123
[07:02:12] info :: [ebuyer] Running linksBuilder...
[07:02:13] info :: [box] Running linksBuilder...
[07:02:14] info :: [very] Running linksBuilder...
[07:02:14] info :: ✖ [ebuyer] [asus (3060ti)] ti tuf oc :: OUT OF STOCK
[07:02:15] info :: [ccl] Running linksBuilder...
[07:02:15] info :: [novatech] Running linksBuilder...
[07:02:15] info :: ✖ [ebuyer] [gigabyte (3060ti)] ti pro oc :: OUT OF STOCK
[07:02:16] info :: [awd] Running linksBuilder...
[07:02:16] info :: [overclockers] Running linksBuilder...
[07:02:16] info :: [scan] Running linksBuilder...
[07:02:16] warn :: ✖ [ccl] [asus (3060ti)] ti dual mini :: CLOUDFLARE, WAITING
[07:02:16] info :: [currys] Running linksBuilder...
[07:02:16] info :: ✖ [ebuyer] [zotac (3060ti)] ti twin edge oc :: OUT OF STOCK
[07:02:18] info :: ✖ [ebuyer] [palit (3060ti)] ti pro :: OUT OF STOCK
[07:02:18] info :: ✖ [ebuyer] [msi (3060ti)] ti ventus 2x oc :: OUT OF STOCK
[07:02:19] info :: ✖ [ebuyer] [asus (3060ti)] ti rog strix oc :: OUT OF STOCK
[07:02:20] info :: ✖ [scan] [evga (3060ti)] ti ftw3 ultra :: OUT OF STOCK
[07:02:20] info :: ✖ [amazon-uk] [msi (3060ti)] ventus 2x oc :: OUT OF STOCK
[07:02:20] info :: ✖ [ebuyer] [asus (3060ti)] ti dual oc :: OUT OF STOCK
[07:02:21] info :: ✖ [scan] [gigabyte (3060ti)] ti pro oc :: OUT OF STOCK
[07:02:21] info :: ✖ [ebuyer] [evga (3060ti)] ti xc oc :: OUT OF STOCK
[07:02:23] info :: ✖ [ebuyer] [gigabyte (3060ti)] ti oc :: OUT OF STOCK
[07:02:23] info :: ✖ [scan] [asus (3060ti)] ti dual oc :: OUT OF STOCK
[07:02:23] info :: ✖ [amazon-uk] [msi (3060ti)] ventus 2x oc :: OUT OF STOCK
[07:02:23] info :: ✖ [ebuyer] [zotac (3060ti)] ti twin edge :: OUT OF STOCK
[07:02:24] info :: ✖ [scan] [gigabyte (3060ti)] ti eagle :: OUT OF STOCK
[07:02:24] info :: ✖ [ebuyer] [gigabyte (3060ti)] ti eagle oc :: OUT OF STOCK
[07:02:25] info :: ✖ [currys] [gigabyte (3060ti)] ti oc :: OUT OF STOCK
[07:02:25] info :: ✖ [ebuyer] [palit (3060ti)] ti dual oc :: OUT OF STOCK
[07:02:25] info :: ✖ [ccl] [asus (3060ti)] ti dual mini :: OUT OF STOCK
[07:02:25] info :: ✖ [scan] [pny (3060ti)] ti uprising dual :: OUT OF STOCK
[07:02:25] info :: ✖ [ebuyer] [asus (3060ti)] ti rog strix :: OUT OF STOCK
[07:02:26] warn :: ✖ [ccl] [zotac (3060ti)] ti twin edge oc :: CLOUDFLARE, WAITING
[07:02:26] info :: ✖ [ebuyer] [asus (3060ti)] ti dual :: OUT OF STOCK
[07:02:26] info :: ✖ [currys] [msi (3060ti)] ti x trio :: PRICE 470 EXCEEDS LIMIT 420
calwe commented 3 years ago

After messing around with a few things, such as the dotenv and the actual source code (wanted to further understand how it worked), I have discovered the issue is related to currys being shown as in stock, even though it is out of stock. I believe this is related to the fact they list the price of there items, despite there being no stock.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] commented 3 years ago

This issue has been closed because it is stale. Reopen if necessary.