Closed Bruner4 closed 2 years ago
Same thing happening to me for amazon-es
This problem is addressed on fix(amazon-eu): checking price selector #2856
@jef Goodmorning everybody, I also noticed the same issue, inspected dom elements and found that the element showing price is called:
a-price-whole
changing "name_of_the_store".ts to inspect that tag seems to make the software works, but please don't get my words for granted since my actual knowledge of this software is very limited at the moment. Maybe someone with more grasp on it, can confirm or deny my assumption
Good morning, first of all sorry, but I wrote store.ts but what I meant was "name of the store".ts
@.***
The line circled in red is the one that works with the tag I suggested in my comment, the small caveat is that it does scrape only the integer part of the price, but it seems like a good compromise. I think also the span with class name "a-offscreen" can be used since it contains the whole price plus currency, but I didn't test that Have a good day,
Diego Lisi
FSTechnology S.p.A. Sourcing Plan, Sustainability & Risk Rapid Solution Prototyping
cell. 331 616 7962 Via Salandra 13, 00187 ROMA
Rispetta l'ambiente: se non Γ¨ necessario, non stampare questa mail
Da: schroedaa @.> Inviato: domenica 6 marzo 2022 12:15 A: jef/streetmerchant @.> Cc: LISI DIEGO @.>; Mention @.> Oggetto: Re: [jef/streetmerchant] [Bug]: Amazon-it is ignoring MAX_PRICE_SERIES filter (Issue #2889)
@dlisihttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdlisi&data=04%7C01%7C%7C884a1fc393e741631cce08d9ff629220%7C4c8a6547459a4b75a3dcf66efe3e9c4e%7C0%7C0%7C637821621692275239%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2FVajGgXX9EDRLZXVA6EDjrbRF%2F2INkmMc9o35qFkVHE%3D&reserved=0 Can you show which point exactly in the Store.ts needs to be changed? Thanks a lot
- Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjef%2Fstreetmerchant%2Fissues%2F2889%23issuecomment-1059942733&data=04%7C01%7C%7C884a1fc393e741631cce08d9ff629220%7C4c8a6547459a4b75a3dcf66efe3e9c4e%7C0%7C0%7C637821621692275239%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Zj2L%2BpMK5iBNIw%2B91GiYJo1uM8Cxs1j0Ns4yow8LmDQ%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXPUNUXOIF3SPONA4PBO4KTU6SHTNANCNFSM5KQ75SBA&data=04%7C01%7C%7C884a1fc393e741631cce08d9ff629220%7C4c8a6547459a4b75a3dcf66efe3e9c4e%7C0%7C0%7C637821621692275239%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=iLMwzU2tVFieTzhiZm0IVIWdmOnWR6sz7ifOsy6wcbE%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C884a1fc393e741631cce08d9ff629220%7C4c8a6547459a4b75a3dcf66efe3e9c4e%7C0%7C0%7C637821621692275239%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=frmycSJQV%2Bckxotp%2FVzLMBIzSd8S2xDUzAXfP6jcDK0%3D&reserved=0 or Androidhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C884a1fc393e741631cce08d9ff629220%7C4c8a6547459a4b75a3dcf66efe3e9c4e%7C0%7C0%7C637821621692275239%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8Iezdt9ucfMY106Pm4upoQOseWrED5Pfr3kSEvtc5NA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days
This issue has been closed because it is stale. Reopen if necessary.
Expected Behavior
Streetmerchant should have ignored the amazon-it items that were coming back with higher price tags than what was specified in the MAX_PRICE_SERIES filter.
Current Behavior
Streetmerchant is instead accepting amazon-it items that have a higher price tag than what is specified in the MAX_PRICE_SERIES filter
.
What operating system are you seeing the problem on?
Windows
Relevant log output
Configuration
Code of Conduct