search

jef / streetmerchant

🤖 The world's easiest, most powerful stock checker
https://jef.buzz/streetmerchant
MIT License
4.96k stars 1.31k forks source link

Best Buy CA False positive EVGA 3080 #490

Closed MrRobot245 closed 3 years ago

MrRobot245 commented 3 years ago

Description

Looks like the BB site loads initially to an In Stock button, but then loads the out of stock message. Snatcher doesnt pick up on this, and only sends a false positive

https://www.bestbuy.ca/en-ca/product/evga-nvidia-geforce-rtx-3080-xc3-ultra-gaming-10gb-gddr6x-video-card/14961449

Possible solution

Wait on page for longer?

jxjftw commented 3 years ago

Front end waiting for api call for stock - needs to add specified wait time if the page is going to be scraped.

maxcroy1 commented 3 years ago

Just wanted to add that this is happening for multiple products - I encountered the same issue this morning with PS5 and ASUS 3080 Strix. Looks like it is showing positive even if the PDP says "Sold Out"

3080 PDP: https://www.bestbuy.ca/en-ca/product/asus-rog-strix-geforce-rtx-3080-10gb-gddr6x-video-card/14954116?intl=nosplash

PS5 PDP: https://www.bestbuy.ca/en-ca/product/playstation-5-console-online-only/14962185?intl=nosplash

phtp commented 3 years ago

Seems like it needs a 2-3 second delay.

jef commented 3 years ago

I believe this was fixed by using the disabled add to cart button. @maxcroy1, have you gotten any more pings after pulling latest?

phtp commented 3 years ago

I updated last night and not getting any more false positives. Thanks!

Brydom commented 3 years ago

@jef I am getting lots of false positives on EVGA 3070/3080 on bestbuy-ca right now.

Specifically these entries:

    // {
    //   brand: 'evga',
    //   model: 'xc3 ultra',
    //   series: '3080',
    //   url:
    //     'https://www.bestbuy.ca/en-ca/product/evga-geforce-rtx-3080-xc3-ultra-gaming-10gb-gddr6x-video-card/15084753?intl=nosplash',
    // },
// {
//   brand: 'evga',
//   model: 'xc3 ultra',
//   series: '3070',
//   url:
//     'https://www.bestbuy.ca/en-ca/product/evga-geforce-rtx-3070-xc3-ultra-8gb-gddr6-video-card/15147122?intl=nosplash',
// },