jeff-dh / SolidPython

A python frontend for solid modelling that compiles to OpenSCAD
143 stars 25 forks source link

Rotate parameter "a" is being treated like a vector when given any number type #5

Closed cromachina closed 2 years ago

cromachina commented 2 years ago

Minimal example of the issue:

>>> from solid2 import *
>>> rotate(1.0, [0,0,1])
rotate(a = [1.0000000000], v = [0, 0, 1]);

This should instead produce:

rotate(a = 1.0000000000, v = [0, 0, 1]);
jeff-dh commented 2 years ago

I guess it's fixed. Check out the head of https://github.com/jeff-dh/SolidPython/tree/master-2.0.0-beta-dev

cromachina commented 2 years ago

Seems to work, thanks! 👍