search

jeff-hughes / shellcaster

Terminal-based podcast manager built in Rust
GNU General Public License v3.0
199 stars 13 forks source link

Add update_details_panel for right/left #17

Closed a-kenji closed 4 years ago

a-kenji commented 4 years ago

The details panel is "detaching" from the episode panel when going right/left this still happens, but now it is consistent with up/down and it happens for a short amount of time.

jeff-hughes commented 4 years ago

Hey, sorry it's taken me a bit to get to this, but it looks great! Thanks so much for the contribution!

I did make a small adjustment, basically because when moving left to right, the details panel doesn't need to be fully recreated. It's only moving up and down where the current podcast/episode is changing. However, one thing your fix does is refresh the ncurses window, which means those little corner pieces get redrawn. So I've just adjusted it so it only refreshes the window, instead of fully erasing and recreating everything. I imagine this makes all of a nanosecond of difference, but...

At any rate, I'll merge this in just a second. Thanks for the change, every little bit helps :)

a-kenji commented 4 years ago

Awesome! No problem - stuff takes time. The change makes sense!