search

jeff-hughes / shellcaster

Terminal-based podcast manager built in Rust
GNU General Public License v3.0
199 stars 13 forks source link

The published date is sometimes strangely formatted #36

Closed Elcoid closed 2 years ago

Elcoid commented 3 years ago

The issue doesn't seem to be easily reproducible, but I was able to see it a few times. The date is sometimes formatted as in the screenshot below, with a space missing between the month and the day, and an extra 1 after the year: ksnip_20210721-145758

This only seems to occur when the list of episodes is scrolled down. When the problematic episodes are displayed when the list is scrolled up, the date is correctly displayed. See these two videos for example:

https://user-images.githubusercontent.com/47006046/126553076-b49d695c-d01b-41b9-bc58-64f8042a7a63.mp4

https://user-images.githubusercontent.com/47006046/126553090-84331249-825d-4219-873a-e98b7ca43577.mp4

jeff-hughes commented 3 years ago

I don't seem to get any actual video from those files, unfortunately. Not sure what's happening there. Is it possible for you to upload them elsewhere and link to them?

At any rate....hmm, that's not a bug I've experienced, and I don't think I have a good theory for how it could be happening. It's a little odd if it's only happening when scrolling down but not up...

Could you let me know:

Elcoid commented 3 years ago

Sure, here are links. For some reason however, I'm not able to watch them directly in Firefox. But I can download them and watch them with vlc or mpv.

This Week in Linux, episode 141: https://user-images.githubusercontent.com/47006046/126553090-84331249-825d-4219-873a-e98b7ca43577.mp4

Darknet Diaries, episodes 82-84: https://user-images.githubusercontent.com/47006046/126553076-b49d695c-d01b-41b9-bc58-64f8042a7a63.mp4

I'm on Artix Linux with Konsole 21.04.3 and shellcaster-bin 1.2.0-1 installed from the AUR.

jeff-hughes commented 3 years ago

Thanks for that -- same thing happens to me, the video didn't show up in Firefox, but downloading them worked. Weird.

Anyway, I added the two feeds you shared, and using the latest release of shellcaster I was able to replicate what you were seeing. My best guess at this point is that it seems to be ncurses not always properly refreshing the line of text for some reason. Not sure exactly why that's happening -- more likely to be something I've done wrong given that ncurses is pretty stable at this point. But it looks like if the previous line was longer, sometimes writing a shorter line will leave some artifacts. That might not be the full story -- I also saw things like "January117" instead of "January 17", so that extra 1 instead of a space is coming from somewhere. Same thing with your screenshot where "March7" is missing the space. But I'd really have to do some more extensive testing since it seems a little inconsistent.

However, the development branch of shellcaster does seem to fix the issue. In that branch I've completely pulled out ncurses entirely and am using crossterm (a Rust-native terminal library) instead. I don't currently recommend using the development branch as it's still a work in progress; there are definitely some bugs to work out there as well that may be more annoying to you than oddly formatted dates :) But either way, it appears that crossterm is doing the job properly, so the next release of shellcaster should fix the issue. I'm still wanting to add some more features before release, but that release will be coming.......sometime. Whenever I stop procrastinating!

Elcoid commented 3 years ago

The important part is that the bug will not be in the next release, which is all that counts for such a minor bug :+1:

jeff-hughes commented 2 years ago

Releasing v2.0 took a lot longer than I expected it to take, so apologies for the delay. But I believe this bug is resolved with the new version.