search

jeff-hughes / shellcaster

Terminal-based podcast manager built in Rust
GNU General Public License v3.0
199 stars 12 forks source link

Shellcaster froze with this message #37

Closed Elcoid closed 2 years ago

Elcoid commented 2 years ago

Hello, Shellcaster froze at the page for downloading new episodes after syncing the podcasts. It happened just as the highlight came to the bottom of the visible part of the list, before it could scroll down. This message appeared at the top of the screen: ksnip_20210804-083225

I wasn't able to see if the bug was reproducible, since my podcasts were already synced after I Ctrl+C'ed and relaunched Shellcaster, and the download page did not appear in this case.

jeff-hughes commented 2 years ago

Hmm...based on that, my best guess is that there's an off-by-one error in the code. I'll have to take a look -- thanks for raising this!

jeff-hughes commented 2 years ago

So, I haven't been able to replicate this issue at all, but there's been substantial changes to the code for scrolling, etc. in v2.0 as a result of the switch to a new terminal UI library. So I'm going to close this, but feel free to reopen if it is still a problem, and ideally if you can find a way to replicate it consistently.

Elcoid commented 2 years ago

I don't seem to see the problem in the new version, fantastic!

Actually, I was able to replicate the problem pretty consistently in the previous version. If I reloaded my feeds and had more new podcasts than what could fit in my terminal, scrolling down eventually caused the freeze. But I haven't seen this problem in the new version so far.

jeff-hughes commented 2 years ago

Awesome, great to hear it's working now!