search

jeff-hykin / better-cpp-syntax

💾 The source of VS Code's C++ syntax highlighting
GNU General Public License v3.0
155 stars 30 forks source link

Another conversion bug `$reference(directive)` #649

Open RedCMD opened 1 year ago

RedCMD commented 1 year ago

I assume $reference(directive) should be $7 "name":"meta.preprocessor.diagnostic.$reference(directive).cpp"

at char 61500 under "diagnostic" https://github.com/jeff-hykin/better-cpp-syntax/blob/master/autogenerated/cpp.embedded.macro.tmLanguage.json

image

would it be because "name" is referencing a "begin" rather than a "match"?

EDIT: also same in cpp https://github.com/jeff-hykin/better-cpp-syntax/blob/db4a681695f3d9c825baaec0e5d699baa7d33b96/autogenerated/cpp.tmLanguage.json#L3284

jeff-hykin commented 11 months ago

would it be because "name" is referencing a "begin" rather than a "match"?

Probably. But it's weird the grammar generator doesn't throw an error when it sees a $reference that it can't resolve. I'll have to look into that some time