search

jeff-hykin / better-shell-syntax

💾 📦 ♻️ An improvement to the shell syntax for VS Code
MIT License
52 stars 4 forks source link

The highlight is incorrect when we are mixed using the backquote and double quotation marks. #48

Closed ivanzhang1 closed 7 months ago

ivanzhang1 commented 1 year ago

The code with a problem is:

// code or link to code
#!/bin/sh
if [ ! -d $source_configs_path ]; then
    echo -e `date "+%Y-%m-%d %H:%M:%S" `"[$FUNCNAME] ""The desination path of source_config doesn't exist..."
    mkdir -p $source_configs_path
fi

It looks like:

screenshot + theme name preferable Theme is default, didn't do any changes once installation is done. image

It should look like:

description of ideal it is highlighted as below once we uninstalled our extension. image

ivanzhang1 commented 1 year ago

vscode 1.73.1 better shell syntax v1.4.1 our code is shell script

jeff-hykin commented 1 year ago

So there's two problems, the backticks being one of them, and the other being that command-name is somehow including the first double quote and then not closing itself.

I pushed a fix for the command name, so at least it doesn't ruin everything. The backtick pattern is still one of the old grammars patterns I haven't gotten around to modernizg so I'll have to do that some point in the future.

ivanzhang1 commented 1 year ago

Thanks for your fixes. Right now, i'm using v1.4.2.

jeff-hykin commented 7 months ago

Okay I think this is fully fixed now, v1.8.5