Open Alecton4 opened 2 months ago
Yeah I need to update the readme, VS Code started using this repo as the source of their shell syntax so its effectively built-in. Which is why you probably won't notice anything unless its one of the recently fixed issues like local vars or case statement stuff.
In terms of "running" I don't think any syntax grammars will be classified as "running" since they're just a json file. The VS Code parser just looks at the JSON file to know how to parse.
For the "it looks like" vs "expected" did you want the brackets to be red? I don't see any other differences
VS Code started using this repo
That's nice!
For the "it looks like" vs "expected"
Some underline rendering disappears, e.g., in the last three lines. Is this intended in the current version? If so then it's totally fine.
Some underline rendering disappears, e.g., in the last three lines. Is this intended in the current version? If so then it's totally fine.
Oh, yes! Thats a theme change. I'm also the owner of the XD theme and I've gone back and fourth on underlining unquoted args. I took them off, and I would kind of like to add them back. I believe the reason I took them out was because sometimes stuff like a$(which hi)b
was all underlined and felt kinda weird. Like yes, its one arg and it'd be nice to underline each argument, but on the other hand which
is a command so it probably shouldnt be underlined.
I'll keep this open till I update the readme
How do we confirm the extension is running? I used the "Developer: Show Running Extensions" command in VSCode, but didn't see this extension being on the list. Also, I tried enabling and then disabling the extension, but it seemed the code highlighting had no change.
The code with a problem is:
Example code in README:
It looks like:
Theme: XD Theme MixItUp
It should look like:
As in README.