search

jeff-hykin / code-eol

💾 ⭐️ An extension to display line endings in VS Code
https://marketplace.visualstudio.com/items?itemName=sohamkamani.code-eol
MIT License
19 stars 4 forks source link

How do I set the "error-color"? #13

Open hintron opened 8 months ago

hintron commented 8 months ago

I don't see a way to set error-color. Right now, my error color is an unhelpful gray, and I want it to be a bright red and maybe with a background style.

jeff-hykin commented 8 months ago

Sure thing, just add this to your settings!

{

    /* [ other settings */

    "code-eol.newlineCharacterStyle": {
        "color": "#ff0000",
    },
    "code-eol.crlfCharacterStyle": {
        "color": "#ff0000",
    },

    /* [ other settings */
}

I don't know if background color can be set, but that style^ gets sent straight to the VS Code API so if there is a way, it should be possible.

Let me know if you have any issues

hintron commented 8 months ago

That's just the regular color, and that works great! But I was hoping to customize the color the line endings get when the setting is turned on that marks wrong line endings. There is an error-color mentioned in the docs that I can't seem to figure out how to set

jeff-hykin commented 8 months ago

Well actually that might explain the gray-color issue. Maybe this isn't the best logic, probably wasn't intentional when I wrote the code, but the settings-color overrides the error-color. So if you set the color of the endings manually, then it won't use the theme's error color. (I was thinking gray was a really weird error color)

So for now, if you don't set the color it'll be the theme's errorForeground , which you shold be able to override in the settings ("workbench.colorCustomizations" I think).

But in the meantime I'll open the issue back up to fix that logic