jeff-regier / Celeste.jl

Scalable inference for a generative model of astronomical images
MIT License
183 stars 28 forks source link

improve brightness scores #710

Closed jeff-regier closed 6 years ago

jeff-regier commented 6 years ago

Improves brightness scores by filtering out light sources from locations where the sky intensity dimmer than it should be. Basically fixes the flux point estimates by excluding around 20% of light sources.

│ Row │ N   │ first     │ second    │ diff       │ diff_sd    │ field           │
├─────┼─────┼───────────┼───────────┼────────────┼────────────┼─────────────────┤
│ 1   │ 129 │ 0.0775194 │ 0.0775194 │ 0.0        │ 0.0213178  │ missed_stars    │
│ 2   │ 353 │ 0.0396601 │ 0.0509915 │ -0.0113314 │ 0.010402   │ missed_galaxies │
│ 3   │ 482 │ 0.267632  │ 0.265964  │ 0.00166788 │ 0.00634124 │ position        │
│ 4   │ 384 │ 0.179285  │ 0.147537  │ 0.0317479  │ 0.0106464  │ flux_r_mag      │
│ 5   │ 384 │ 0.655357  │ 0.64015   │ 0.0152074  │ 0.0478577  │ flux_r_nmgy     │
│ 6   │ 105 │ 16.9819   │ 15.5799   │ 1.40192    │ 1.31291    │ gal_angle_deg   │
│ 7   │ 211 │ 0.260781  │ 0.187022  │ 0.0737584  │ 0.0215299  │ gal_frac_dev    │
│ 8   │ 211 │ 0.199889  │ 0.145787  │ 0.0541026  │ 0.0103492  │ gal_axis_ratio  │
│ 9   │ 211 │ 1.29034   │ 0.612578  │ 0.677761   │ 0.331698   │ gal_radius_px   │
│ 10  │ 371 │ 1.0283    │ 0.575659  │ 0.452643   │ 0.0498698  │ color_ug        │
│ 11  │ 473 │ 0.338041  │ 0.175434  │ 0.162607   │ 0.0204756  │ color_gr        │
│ 12  │ 481 │ 0.201293  │ 0.126392  │ 0.0749017  │ 0.0124566  │ color_ri        │
│ 13  │ 477 │ 0.386288  │ 0.189743  │ 0.196545   │ 0.0235967  │ color_iz        │
codecov[bot] commented 6 years ago

Codecov Report

Merging #710 into master will increase coverage by 0.07%. The diff coverage is 75.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   80.86%   80.93%   +0.07%     
==========================================
  Files          35       35              
  Lines        3673     3697      +24     
==========================================
+ Hits         2970     2992      +22     
- Misses        703      705       +2
Impacted Files Coverage Δ
src/deterministic_vi/ElboMaximize.jl 100% <ø> (ø) :arrow_up:
src/model/param_set.jl 15% <ø> (ø) :arrow_up:
src/mcmc/mcmc_functions.jl 45.94% <0%> (ø) :arrow_up:
src/deterministic_vi/elbo_kl.jl 51.19% <0%> (ø) :arrow_up:
src/GalsimBenchmark.jl 100% <100%> (ø) :arrow_up:
src/model/imaged_sources.jl 100% <100%> (ø) :arrow_up:
src/Synthetic.jl 74.57% <100%> (ø) :arrow_up:
src/BivariateNormals.jl 100% <100%> (ø) :arrow_up:
src/joint_infer.jl 70.37% <100%> (+0.1%) :arrow_up:
src/Transform.jl 55.77% <100%> (ø) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc6730...bd9f094. Read the comment docs.