search

jeff-regier / Celeste.jl

Scalable inference for a generative model of astronomical images
MIT License
183 stars 28 forks source link

remove RawImage type #718

Closed kbarbary closed 6 years ago

kbarbary commented 6 years ago

Removes RawImage, the SDSS specific version of Image, was very similar to Image, and only used in one place outside of SDSSIO. After this, the only image-reading interface is SDSSIO.load_field_images(strategy, rcf), which returns a Vector{Image}; no need for RawImage.

A lot of the changeset here is just moving IOStrategy stuff earlier in the SDSSIO module (so that we can dispatch on it in functions below).

codecov[bot] commented 6 years ago

Codecov Report

Merging #718 into master will increase coverage by 0.07%. The diff coverage is 93.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   80.03%   80.11%   +0.07%     
==========================================
  Files          37       37              
  Lines        4033     4013      -20     
==========================================
- Hits         3228     3215      -13     
+ Misses        805      798       -7
Impacted Files Coverage Δ
src/model/image_model.jl 33.33% <100%> (+8.33%) :arrow_up:
src/ParallelRun.jl 84.35% <60%> (+1.33%) :arrow_up:
src/SDSSIO.jl 94.64% <95.58%> (+0.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c26d1b...265687a. Read the comment docs.