Closed kbarbary closed 6 years ago
Merging #729 into master will increase coverage by
0.07%
. The diff coverage is94.44%
.
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
+ Coverage 81.5% 81.57% +0.07%
==========================================
Files 38 39 +1
Lines 3937 3963 +26
==========================================
+ Hits 3209 3233 +24
- Misses 728 730 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/ParallelRun.jl | 84.87% <100%> (-1.01%) |
:arrow_down: |
src/AccuracyBenchmark.jl | 78.26% <100%> (ø) |
:arrow_up: |
src/GalsimBenchmark.jl | 100% <100%> (ø) |
:arrow_up: |
src/config.jl | 100% <100%> (ø) |
:arrow_up: |
src/dataset.jl | 33.33% <33.33%> (ø) |
|
src/SDSSIO.jl | 97.15% <94.3%> (-0.89%) |
:arrow_down: |
src/main.jl | 97.29% <97.29%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f2cc669...4ee39a3. Read the comment docs.
Looks good!
This implements a "dataset" interface that can be fulfilled by different datasets, SDSS being one. The main interface is to create a dataset object, then call
load_images(dataset, box)
. The specific dataset implementation determines where to find images overlapping the box, how to load files, and how to create CelesteImage
s from them.Add an abstract SurveyDataSet type, to be subtyped by actual implementations of datasets.
Implement SDSSDataSet <: SurveyDataSet, implementing how to create Celeste
Image
s from SDSS data on disk. Options inSDSSDataSet
formerly lived inIOStrategy
, whichSDSSDataSet
replaces.Move implementation of command-line script
bin/infer-box.jl
into package inmain.jl
in order to easily facilitate testing.Read both general configuration and dataset configuration from yaml file (formerly done in settings.jl, now done in main.jl).