jeff-regier / Celeste.jl

Scalable inference for a generative model of astronomical images
MIT License
183 stars 28 forks source link

Add SurveyDataSet, implement SDSSDataSet #729

Closed kbarbary closed 6 years ago

kbarbary commented 6 years ago

This implements a "dataset" interface that can be fulfilled by different datasets, SDSS being one. The main interface is to create a dataset object, then call load_images(dataset, box). The specific dataset implementation determines where to find images overlapping the box, how to load files, and how to create Celeste Images from them.

codecov[bot] commented 6 years ago

Codecov Report

Merging #729 into master will increase coverage by 0.07%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage    81.5%   81.57%   +0.07%     
==========================================
  Files          38       39       +1     
  Lines        3937     3963      +26     
==========================================
+ Hits         3209     3233      +24     
- Misses        728      730       +2
Impacted Files Coverage Δ
src/ParallelRun.jl 84.87% <100%> (-1.01%) :arrow_down:
src/AccuracyBenchmark.jl 78.26% <100%> (ø) :arrow_up:
src/GalsimBenchmark.jl 100% <100%> (ø) :arrow_up:
src/config.jl 100% <100%> (ø) :arrow_up:
src/dataset.jl 33.33% <33.33%> (ø)
src/SDSSIO.jl 97.15% <94.3%> (-0.89%) :arrow_down:
src/main.jl 97.29% <97.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2cc669...4ee39a3. Read the comment docs.

jeff-regier commented 6 years ago

Looks good!